Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-validator: add version 2.1.1 #23978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toge
Copy link
Contributor

@toge toge commented May 13, 2024

Specify library name and version: cpp-validator/2.1.1

evgeniums/cpp-validator@v2.0.3...v2.1.1


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (9c7bdbd641daff0ebfcf56985d856e5bd3de9106):

  • cpp-validator/2.1.1:
    All packages built successfully! (All logs)

  • cpp-validator/2.0.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (9c7bdbd641daff0ebfcf56985d856e5bd3de9106):

  • cpp-validator/2.1.1:
    All packages built successfully! (All logs)

  • cpp-validator/2.0.3:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking https://github.com/evgeniums/cpp-validator/blob/main/docs/index.md#building-and-installation (To see if it makes sense to open a PR upstream to mention Conan support) - and noticed the bit about fmt backend needing a define to properly work. Isn't this something that should be reflected in the recipe? Both as an option, and in the package_info? wdyt @toge?

@memsharded
Copy link
Member

I'm checking https://github.com/evgeniums/cpp-validator/blob/main/docs/index.md#building-and-installation (To see if it makes sense to open a PR upstream to mention Conan support) - and noticed the bit about fmt backend needing a define to properly work. Isn't this something that should be reflected in the recipe? Both as an option, and in the package_info? wdyt @toge?

Maybe the recipe can hardcode at the moment the fmt backend, as it is recommended and preferred, but the HATN_VALIDATOR_FMT macro seems it should be defined in consumers, not sure why the test_package is not failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants