Fix zlib compilation on conan and AppleClang 12.0 #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
uilianries
requested changes
Aug 4, 2020
There was a problem hiding this comment.
Hi @yamadapc ! Thanks for your contribution, please, take a look on my review
Closed
yamadapc
force-pushed
the
bug/fix-zlib-on-clang-12
branch
from
c676b2f
to
674d02e
Compare
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
yamadapc
force-pushed
the
bug/fix-zlib-on-clang-12
branch
from
674d02e
to
3602ea3
Compare
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
yamadapc
commented
Aug 5, 2020
| '/* may be set to #if 1 by ./configure */', | ||
| '#if defined(HAVE_STDARG_H) && (1-HAVE_STDARG_H-1 != 0)') | ||
|
|
||
| is_apple_clang12 = self.settings.compiler == "apple-clang" and tools.Version(self.settings.compiler.version) >= "12.0" |
There was a problem hiding this comment.
It should now run the replaces unless on AppleClang >= "12.0"
uilianries
previously approved these changes
Aug 5, 2020
I'm not sure what these replaces were doing. Disabled them if on AppleClang 12.0 or higher. Related to: - boostorg/build#638 - madler/zlib#509
yamadapc
force-pushed
the
bug/fix-zlib-on-clang-12
branch
from
3602ea3
to
56ddf38
Compare
|
Forced push to re-trigger the build. Please have another look. Thanks |
|
All green in build 4 (
|
jgsogo
approved these changes
Aug 17, 2020
SSE4
approved these changes
Aug 17, 2020
uilianries
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what these replaces were doing.
Happy to create a new recipe if that is a safer change, since I just don't know what the replaces were doing, this just fixed it on my computer™️.
c.c. @lasote who wrote the recipe.
Related to:
Introduced in #1
Specify library name and version: zlib/1.2.11
conan-center hook activated.