Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msdfgen: update tinyxml2 dependency to 10.0.0 #24115

Merged
merged 3 commits into from
May 29, 2024

Conversation

Sahnvour
Copy link
Contributor

Specify library name and version: msdfgen/1.10

Somewhat recent versions of Musl, used in Alpine Linux in particular, removed support for glibc extensions functions.
Version 9.0.0 made use of these, 10.0.0 does not anymore. cf leethomason/tinyxml2#945


@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes May 27, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, the version bump in this case makes lots of sense, thanks a lot for the explanation and linking further info, really appreciated :)

@AbrilRBS AbrilRBS self-assigned this May 27, 2024
@conan-center-bot conan-center-bot added Bump dependencies Only bumping dependencies versions in the recipe Failed and removed Waiting for CI labels May 27, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented May 28, 2024

@Sahnvour let me know if you need any help tackling the compilation issue reported by the bot :)

Edit: Oh, seems like this is endemic to all PRs for this recipe, I'll investigate myself, sorry for the noise!

@conan-center-bot conan-center-bot removed Failed Bump dependencies Only bumping dependencies versions in the recipe labels May 28, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (1c747672cedae6265c134283617a2459cc6dec5e):

  • msdfgen/1.10:
    All packages built successfully! (All logs)

  • msdfgen/1.11:
    All packages built successfully! (All logs)

  • msdfgen/1.9.1:
    All packages built successfully! (All logs)

  • msdfgen/1.9:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (1c747672cedae6265c134283617a2459cc6dec5e):

  • msdfgen/1.11:
    All packages built successfully! (All logs)

  • msdfgen/1.10:
    All packages built successfully! (All logs)

  • msdfgen/1.9:
    All packages built successfully! (All logs)

  • msdfgen/1.9.1:
    All packages built successfully! (All logs)

@Sahnvour
Copy link
Contributor Author

Thanks for handling it :)

@conan-center-bot conan-center-bot merged commit e963286 into conan-io:master May 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants