[boost] Check for C++20 compiler support when building Cobalt #24149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers @paulharris you might be interested. 😉 |
This was referenced May 29, 2024
Merged
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit 17e9b7aboost/1.85.0@#db9b7d91e0ad8ba0b5878eb24601edb7boost/1.81.0@#44f903c7690d66225351d90b738787bcboost/1.73.0@#5375ddc1568645bb2dee98a7e2a8dbdfboost/1.84.0@#b5dcda38cd49cbfedbb80dd939115ea6boost/1.82.0@#2beb8afb021d92523db42e16db2dc946boost/1.79.0@#612c9e8e2dc8103669fa626ad240ca3dboost/1.80.0@#c0dced27fd872f001b859837478ae355boost/1.83.0@#99a01316f748f2c9fcd163408217b5a1boost/1.78.0@#76ab0d03d2bab6a37a393e76b96de1feboost/1.74.0@#bbbd7847c6caeabba3bddf2fbdf7664aboost/1.71.0@#1a3954d4770e3fb7b216e73ff29f2387boost/1.75.0@#e5ea0369ba817cd3c5b8f0c3e0c2f285boost/1.72.0@#fdf235e12b801fd7a378ed217e6950e6boost/1.76.0@#100c13ad2a8317275f84fcda9d32be42boost/1.77.0@#1ff54f24e525d4d1faafce3237ca9391 |
samuel-emrys
suggested changes
May 30, 2024
| def _has_cppstd_20_supported(self): | ||
| cppstd = self.settings.compiler.get_safe("cppstd") | ||
| if cppstd: | ||
| return valid_min_cppstd(self, 20) |
There was a problem hiding this comment.
I suspect that this isn't sufficient to exclude all invalid compilers. valid_min_cppstd returns True for gcc 8, gcc 9, gcc 10, clang 10, clang 11 clang 12 and clang 13 - all of which have partial support for C++20, but the features that cobalt relies on aren't implemented (libstdc++, this may say more about the gcc version installed on the docker images for clang than the clang versions). Unfortunately none of these compiler versions are in the test matrix (or don't have cppstd=20 set), so we're not seeing this reflected in CI
There was a problem hiding this comment.
@uilianries @RubenRBS is this not something the conan team are concerned about?
There was a problem hiding this comment.
@samuel-emrys It's hard to track partial features implemented by compiler as we don't run a code to validate it. Still, if you think is something to be improved, please, open an issue to https://github.com/conan-io/conan/issues.
About Boost, we have a other checks related to the compiler version too, not only valid_min_cppstd. Now, users are suppose the be apart of their compilers, and what features they support. Here we have all those checks to avoid breaking when building, so we can inform in advance.
There was a problem hiding this comment.
@uilianries maybe I'm missing it - I can't see where compiler versions for cobalt are checked for..
The changes you've introduced here only fix part of the problem with cobalt - checking for the required cppstd is important, but gcc < 11 and clang < 14 will return true for your check, and will fail because they miss the necessary features to build cobalt. The result is that our pipelines for these compiler versions fail because boost is trying to build with cobalt which is not supported for these compiler versions.
The problem here is just that cobalt is building by default when valid_min_cppstd(self, 20), but the logic should be Version(self.settings.compiler.version) >= self._min_cobalt_compiler_version() and valid_min_cppstd(self, 20)
Perhaps this check is better placed in config_options than the line I've commented on though.
toge
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: boost/1.85.0
The Boost Cobalt has been introduced in Boost 1.84.0 (changelog and requires C++20 support for coroutines (Jamfile).
The current recipe for Boost only validates C++11 and C++14 (Boost math) compilers, but not C++20 (Cobalt). This PR introduces a new check to validate when building Cobalt: The cppstd should be C++20, or the compiler should be new enough (Conan 1.x).
fixes #24148