Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6: fix resources object files location #24150

Merged
merged 2 commits into from
May 30, 2024

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented May 29, 2024

Specify library name and version: qt/6.7.1

fixes #24131


@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented May 29, 2024

This is a consequence of qt/qtbase@2fb9ac0
The error can be seen in:

It happens when linking to qtWidgets or qtGui:

/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Widgets_resources_2/.qt/rcc: file format not recognized
/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Widgets_resources_4/.qt/rcc: file format not recognized
/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Widgets_resources_1/.qt/rcc: file format not recognized
/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Widgets_resources_3/.qt/rcc: file format not recognized
/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Gui_resources_2/.qt/rcc: file format not recognized
/usr/bin/ld: cannot find /home/conan/workspace/prod-v1/bsr/50590/eacde/.conan/data/qt/6.7.1/_/_/package/c6f9811941e2715cb33edb4bc2b1e217a1780d85/lib/objects-Release/Gui_resources_1/.qt/rcc: file format not recognized

In qt < 6.7.0 these resources were in lib/objects-Release/Gui_resources_1/.rcc but with 6.7.1 they are in lib/objects-Release/Gui_resources_1/.qt/rcc. Notice the added folder level. This PR transitions to using os.walk in order to get all files recursively instead of statically fixing the nesting level by calling os.listdir

@ericLemanissier ericLemanissier changed the title qt: test: link with qtwidgets qt6: fix resources object files location May 29, 2024
@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier marked this pull request as ready for review May 29, 2024 12:05
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Minor question before approving to udnerstand a bit more why we didn't catch this earlier :)

@AbrilRBS AbrilRBS self-assigned this May 29, 2024
@ericLemanissier
Copy link
Contributor Author

We did not catch it because the test recipe links only to Qt6::Core Qt6::Network Qt6::Sql Qt6::Concurrent Qt6::Xml , and none of these modules have resources, contrary to Qt6::Widgets and Qt6::GUI

@ericLemanissier
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 39b1484
qt/6.7.1@#00594bbd5515a248a8280ee2b3b62b91
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.7.0@#f98d0421949abc6fc1ffe764e8b3dfd5
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.1@#1555a62701680c2865e3800ccc86f2cb
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.3@#b9fce4e91c1cef6e2aef123d4b2ef0f8
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.3.2@#57f2bb54211c4cbc45dc34ab0deece81
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.6.0@#4b863bbe6409f49fa1805f42c69c9203
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.2@#4bf27805f471b03f14bcf68eda108f51
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.5.3@#3039026772b946e49f97a21be4af5b83
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.4.2@#8268b72cb006f78ac7b36960a571f062
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (39b1484934e8a60b9e1bf37eb949f6e5b48c804c):

  • qt/6.7.0:
    All packages built successfully! (All logs)

  • qt/6.6.3:
    All packages built successfully! (All logs)

  • qt/6.7.1:
    All packages built successfully! (All logs)

  • qt/6.6.1:
    All packages built successfully! (All logs)

  • qt/6.6.2:
    All packages built successfully! (All logs)

  • qt/6.5.3:
    All packages built successfully! (All logs)

  • qt/6.3.2:
    All packages built successfully! (All logs)

  • qt/6.6.0:
    All packages built successfully! (All logs)

  • qt/6.4.2:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c9a8b7d into conan-io:master May 30, 2024
53 checks passed
@ericLemanissier ericLemanissier deleted the patch-2 branch May 30, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] qt/6.7.1: fatal error LNK1181 on simple hello world project
4 participants