-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6: fix resources object files location #24150
Conversation
This comment has been minimized.
This comment has been minimized.
The build is now finished. You can take a look at the results here |
This is a consequence of qt/qtbase@2fb9ac0
It happens when linking to qtWidgets or qtGui:
In qt < 6.7.0 these resources were in |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Minor question before approving to udnerstand a bit more why we didn't catch this earlier :)
We did not catch it because the test recipe links only to Qt6::Core Qt6::Network Qt6::Sql Qt6::Concurrent Qt6::Xml , and none of these modules have resources, contrary to Qt6::Widgets and Qt6::GUI |
The build is now finished. You can take a look at the results here |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 39b1484qt/6.7.1@#00594bbd5515a248a8280ee2b3b62b91
qt/6.7.0@#f98d0421949abc6fc1ffe764e8b3dfd5
qt/6.6.1@#1555a62701680c2865e3800ccc86f2cb
qt/6.6.3@#b9fce4e91c1cef6e2aef123d4b2ef0f8
qt/6.3.2@#57f2bb54211c4cbc45dc34ab0deece81
qt/6.6.0@#4b863bbe6409f49fa1805f42c69c9203
qt/6.6.2@#4bf27805f471b03f14bcf68eda108f51
qt/6.5.3@#3039026772b946e49f97a21be4af5b83
qt/6.4.2@#8268b72cb006f78ac7b36960a571f062
|
Conan v1 pipeline ✔️All green in build 4 (
|
Specify library name and version: qt/6.7.1
fixes #24131