-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenColorIO: Fix validation & package_info #24395
base: master
Are you sure you want to change the base?
Conversation
* Remove the validation preventing shared building * Add required libraries to package_info
Taking out the relevant parts of #23112 without the build hacks done there by changing linking to public. |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Let me know if you need help fixing the gcc compilation issue/ping me once you figure it out, thanks! :) |
Hey @RubenRBS , thanks for offering help. Just wanted to have a more clean MR as documentation compared to the old one, but the underlying problem is discussed in #23421 and still is true. Looks like it works with gold, I tried mold and kept it for now in my profile and it works well so far. I have no clue what the proper fix for this might be. It just looks like the default linker is requireing to know where to find each indirectly needed so while mold and gold are fine with linking just the direct dependencies. (Populating the LD_LIBRARY_PATH before build makes default linking work too.) |
Summary
Changes to recipe: OpenColorIO/all
Motivation
Ensure more configurations options are properly build. The validation basically prevents all shared builds right now.
Details