-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencv 4.x: add options to enable gstreamer, aravis, gphoto2 & librealsense backends #24495
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0064548opencv/4.5.5@#951a0831c660918eaa27ea887de52850
opencv/4.9.0@#c45c9d83f4ff291f9e06a260144accd5
opencv/4.5.3@#82cf6ac45e64dad750474f2960351656
opencv/4.8.1@#ee6d7d37ebca0d84fc82f441adf8536c
opencv/4.1.2@#4c1ac711dd190510f467f35e063598fe
|
@AbrilRBS @uilianries @danimtb Looks like ffmpeg v2 packages for msvc are missing for some reason (only when shared=True, I guess it comes from RREV update of libvpx due to recent PR #24346 and the fact that libvpx is always static for Windows, leading to its RREV contributing to downstream packages like ffmpeg when they are shared). |
I'll trigger an internal build to generate that missing package. Thank you for pinging. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Working on Conan 1.x. As commented in the PR description, Conan 2.x is not working because
|
Are you sure gstreamer is enabled in your local build with conan v1 client? I don't see gstreamer nor gst-plugins-base in requirements. Souldn't it be |
this option enables aravis backend in videoio module of opencv
this option enables libgphoto2 backend in videoio module of opencv
this option enables librealsense backend in videoio module of opencv
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 24d95c5opencv/4.10.0@#aea5966289334fba9058c02ebfc31aa0
opencv/4.5.3@#dda51a40dec696ea482ea054d349fae3
opencv/4.9.0@#f82407c5fec708455debce42ce6ddf18
opencv/4.8.1@#846ee848a41ee50b4111f210d140f43c
opencv/4.5.5@#8ddb85baf8f03632065bfc13c03cac8a
opencv/4.1.2@#6bb7cac9d1f7fa1f9b1750b4d949113f
|
I've tested on macOS and conan v2 client (+ migration of
opencv 4.10.0/all shared/with gstreamer/macOS/apple-clang15
|
@AbrilRBS @uilianries could you review this one please? I'll submit another PR adding more videoio backends but I prefer to wait for this one to be merged. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6dbecadopencv/4.9.0@#39139d47cc5193cf132d8ae23b0c876e
opencv/4.10.0@#543e5bc3fc1af42d68251936e17f9712
opencv/4.8.1@#8f650517b42d3ba2811fe39c7152a4ba
opencv/4.5.5@#598c4bbeb5523c982d0f43cb99dcd538
opencv/4.1.2@#0367525d605baae56eee111412beb44f
opencv/4.5.3@#6cbc07e64112552d6f35087316dfe3b9
|
@AbrilRBS @uilianries ffmpeg v2 packages have to be re-generated due to #24706 |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 12 (
|
Hooks produced the following warnings for commit 152b595opencv/4.9.0@#b44ee4a9862631aa28034e2448be3353
opencv/4.10.0@#1f51363c77b2d2b732504cf0696aa698
opencv/4.5.5@#98367fcc8c865c19ca670b2218daae6c
opencv/4.1.2@#e6b2e2e7284cc08271c2057c9d2dfb9c
opencv/4.8.1@#aa6cd2649bd6c9b2a72b3c292de614e4
opencv/4.5.3@#f16e55135f0c633094ad44ff6d9cfcd2
|
Summary
Changes to recipe: opencv/4.x
Motivation
This PR adds
with_gstreamer
option toopencv
recipe (for 4.x versions), allowing to enablegstreamer
backend invideoio
module (and ingapi
module since 4.5.5).closes #24486
Details
videoio
(orgapi
since 4.5.5) are not enabled in opencv build, so it's removed in this case.pkgconf
at build time: https://github.com/opencv/opencv/blob/4.9.0/modules/videoio/cmake/detect_gstreamer.cmakedetect_gstreamer.cmake
file.gsteamer
recipe, others ingst-plugins-base
: https://github.com/opencv/opencv/blob/4.9.0/modules/videoio/cmake/detect_gstreamer.cmake#L97-L102gapi
module of OpenCV can depend on gstreamer, but only since 4.5.5: https://github.com/opencv/opencv/blob/4.5.5/modules/gapi/CMakeLists.txt#L303-L311It can be disabled specifically for
gapi
even ifWITH_GSTREAMER
CMake option is enabled, but it would mean another specific option in this complex opencv recipe. I think it's too much, so this PR also enables gstreamer ingapi
as soon aswith_gstreamer
option is enabled (which is the default behavior upstream). One could add another option later.gst-plugins-base
recipe has not been migrated to conan v2.