libxml2: fix include dirs in CMake config file #24649
Conversation
If libxml2_INCLUDE_DIRS is defined, it should be used to set the variables related to the preprocessor's include directories, rather than the variables related to the linker.
|
|
This comment has been minimized.
This comment has been minimized.
|
The custom CMake module can be made considerably simpler altogether and copied from the recipe dir instead of generating it: set(LibXml2_FOUND TRUE)
set(LIBXML2_FOUND TRUE)
set(LIBXML2_INCLUDE_DIR "${${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS}")
set(LIBXML2_INCLUDE_DIRS "${${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS}")
set(LIBXML2_LIBRARIES "${${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS}")
set(LIBXML2_LIBRARY "${${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS}")
set(LIBXML2_DEFINITIONS "${${CMAKE_FIND_PACKAGE_NAME}_DEFINITIONS}")
set(LIBXML2_VERSION_STRING "${${CMAKE_FIND_PACKAGE_NAME}_VERSION}") |
conan-center-bot
added
Unexpected Error
Failed
and removed
User-approval pending
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 7 (
|
Summary
Changes to recipe: libxml2/2.12.7
Motivation
The recipe creates its own CMake config file through the
_create_cmake_module_variables()method.However, the method contains a typo. when the
LibXml2_INCLUDE_DIRSvariable is not defined butlibxml2_INCLUDE_DIRSis, it used its value to setLIBXML2_LIBRARIES&LIBXML2_LIBRARY. This is incorrect, as the two settings are not related (one is used by the preprocessor while the other is used by the linker).This is further evidenced by the fact that the variables
LIBXML2_LIBRARIES&LIBXML2_LIBRARYare later overwritten using the value inLibXml2_LIBRARIESorlibxml2_LIBRARIES(in order of precedence).Details
The PR uses the value of
libxml2_INCLUDE_DIRSto setLIBXML2_INCLUDE_DIR/LIBXML2_INCLUDE_DIRSinstead ofLIBXML2_LIBRARIES/LIBXML2_LIBRARY.