Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sfml/2.5.1 #2467

Closed

Conversation

intelligide
Copy link
Contributor

Specify library name and version: sfml/2.5.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Adapted from bincrafters/conan-sfml

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sfml/2.5.1' failed in build 1 (c895d51e2c3b4103d5f3df971e0a6ed3db25a9b9):

@intelligide intelligide marked this pull request as draft August 8, 2020 21:59
@conan-center-bot
Copy link
Collaborator

Some configurations of 'sfml/2.5.1' failed in build 2 (802d78c6dd3c5f3ed9b032a7aa6f8d2578e6e891):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: sfml:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [SYSTEM REQUIREMENTS (KB-H032)] The method 'SystemPackageTool.install' is not allowed in the recipe. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H032)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

self.cpp_info.names["cmake_find_package_multi"] = "SFML"
self.cpp_info.names["pkg_config"] = "SFML"

self.cpp_info.components["System"].names["cmake_find_package"] = "system"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Components name could be lower case, it would avoid to override cmake_find_package and cmake_find_package_multi.
Personal opinion: since recipes names are always lower case in CCI, I think that always use lowercase for components is more consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, SFML module and config files cannot be properly modeled by conan generators.
Usage is:

find_package(SFML REQUIRED main window audio CONFIG)
target_link_libraries(myapp sfml-main sfml-window sfml-audio)

@intelligide
Copy link
Contributor Author

Waiting for #2468

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sfml/2.5.1' failed in build 3 (8663066dbab668b56d2bdeed47c4bdd9ec346f8d):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: sfml:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [SYSTEM REQUIREMENTS (KB-H032)] The method 'SystemPackageTool.install' is not allowed in the recipe. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H032)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@eigenwhat
Copy link
Contributor

@intelligide please look at FrozenStormInteractive#6.

Fixes:

  • Bumped version of OpenAL to 1.20.1. This fixes a duplicate symbol error when OpenAL 1.19.1 is built on GCC 10. It now sets -fno-common by default which breaks OpenAL due to a few missing externs in its headers. 1.20.1 doesn't have this issue.
  • Added missing "system" component require for the "audio" component.
  • Removed the os.remove commands as they don't seem to be needed and had caused the packaging to fail locally otherwise.

eigenwhat and others added 2 commits November 1, 2020 01:40
sfml: audio component depends on system, bumped openal version
@conan-center-bot
Copy link
Collaborator

Failure in build 4 (3907507cc2a17ccb552ed0361a83224b5ec40c3b):

  • sfml/2.5.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [SYSTEM REQUIREMENTS (KB-H032)] The method 'SystemPackageTool.install' is not allowed in the recipe. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H032)

Comment on lines +56 to +64
def system_requirements(self):
if self.settings.os == 'Linux' and tools.os_info.is_linux:
if tools.os_info.with_apt:
installer = tools.SystemPackageTool()
packages = []
if self.options.window:
packages.extend(['libudev-dev'])
for package in packages:
installer.install(package)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libudev desires a proxy package, libusb also requires libudev, but it's complete outdated.

Copy link
Contributor

@SpaceIm SpaceIm Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an old PR for libudev: #904

Oups, missed that there was this new one #2468

@Croydon Croydon mentioned this pull request Dec 14, 2020
@stale
Copy link

stale bot commented Dec 27, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 27, 2020
@stale
Copy link

stale bot commented Jan 26, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Jan 26, 2021
@Croydon Croydon mentioned this pull request Feb 18, 2021
4 tasks
ericLemanissier added a commit to bincrafters/community that referenced this pull request Jul 20, 2021
CroydonBot pushed a commit to bincrafters/community that referenced this pull request Jul 21, 2021
* sfml/2.5.1

this is the same recipe as https://github.com/bincrafters/conan-sfml/

* update url and topics

also, don't try to package bincrafters license

* add cmake_find_package_multi generator

in order to find conan dependencies instead of the system ones

* implement components

stollen from conan-io/conan-center-index#2467

* fixup components

also, disable bundled dependencies

* nit: newline

Co-authored-by: Michael Keck <git@cr0ydon.com>
@Kidsunbo
Copy link

Kidsunbo commented Sep 2, 2021

So why is this PR closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants