-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sfml/2.5.1 #2467
Add sfml/2.5.1 #2467
Conversation
Some configurations of 'sfml/2.5.1' failed in build 1 (
|
Some configurations of 'sfml/2.5.1' failed in build 2 (
|
recipes/sfml/all/conanfile.py
Outdated
self.cpp_info.names["cmake_find_package_multi"] = "SFML" | ||
self.cpp_info.names["pkg_config"] = "SFML" | ||
|
||
self.cpp_info.components["System"].names["cmake_find_package"] = "system" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components name could be lower case, it would avoid to override cmake_find_package
and cmake_find_package_multi
.
Personal opinion: since recipes names are always lower case in CCI, I think that always use lowercase for components is more consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, SFML module and config files cannot be properly modeled by conan generators.
Usage is:
find_package(SFML REQUIRED main window audio CONFIG)
target_link_libraries(myapp sfml-main sfml-window sfml-audio)
Waiting for #2468 |
Some configurations of 'sfml/2.5.1' failed in build 3 (
|
@intelligide please look at FrozenStormInteractive#6. Fixes:
|
sfml: audio component depends on system, bumped openal version
Failure in build 4 (
|
def system_requirements(self): | ||
if self.settings.os == 'Linux' and tools.os_info.is_linux: | ||
if tools.os_info.with_apt: | ||
installer = tools.SystemPackageTool() | ||
packages = [] | ||
if self.options.window: | ||
packages.extend(['libudev-dev']) | ||
for package in packages: | ||
installer.install(package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libudev desires a proxy package, libusb also requires libudev, but it's complete outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
stollen from conan-io/conan-center-index#2467
* sfml/2.5.1 this is the same recipe as https://github.com/bincrafters/conan-sfml/ * update url and topics also, don't try to package bincrafters license * add cmake_find_package_multi generator in order to find conan dependencies instead of the system ones * implement components stollen from conan-io/conan-center-index#2467 * fixup components also, disable bundled dependencies * nit: newline Co-authored-by: Michael Keck <git@cr0ydon.com>
So why is this PR closed? |
Specify library name and version: sfml/2.5.1
conan-center hook activated.
Adapted from bincrafters/conan-sfml