Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashpad: add version cci.20240812 #24929 #24930

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dcoburnMEDITECH
Copy link

@dcoburnMEDITECH dcoburnMEDITECH commented Aug 13, 2024

Summary

Changes to recipe: crashpad/cci.20240812

Motivation

existing crashpad/cci.20220219 does not support c++20 standard.

Details

This branch updates the crashpad recipe to include the current https://github.com/chromium/mini_chromium and https://github.com/chromium/crashpad mirror as sources to the crashpad recipes.
Updated patches to handle current files.


@CLAassistant
Copy link

CLAassistant commented Aug 13, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 14, 2024
@conan-center-bot

This comment has been minimized.

@ErniGH ErniGH self-assigned this Aug 14, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@dcoburnMEDITECH
Copy link
Author

dcoburnMEDITECH commented Aug 19, 2024

Either we have to put this on hold, and wait/submit compatible with c++17 code, or we will have to make this version of the package c++20 minimum. I feel wrong for not testing and expecting backwards compatibility.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 6 (054d71bcbf4413a3e166a850d845fe35657b74a5):

  • crashpad/cci.20220219:
    Didn't run or was cancelled before finishing

  • crashpad/cci.20240812:
    CI failed to create some packages (All logs)

    Logs for packageID dce385b01e75b0fd931ca02203b6b402d96ba28f:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libc++
    compiler.version=13
    os=Linux
    
    [...]
    #define UNSAFE_BUFFERS(...) __VA_ARGS__
                                ^~~~~~~~~~~
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:884:20: note: 'size' declared here
      constexpr size_t size() const noexcept { return size_; }
                       ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:743:18: error: no member named 'data' in namespace 'std::ranges'; did you mean simply 'data'?
                span(std::ranges::data(range), std::ranges::size(range))) {}
                     ^~~~~~~~~~~~~~~~~
                     data
    ../../third_party/mini_chromium/mini_chromium/base/compiler_specific.h:572:29: note: expanded from macro 'UNSAFE_BUFFERS'
    #define UNSAFE_BUFFERS(...) __VA_ARGS__
                                ^~~~~~~~~~~
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:931:16: note: 'data' declared here
      constexpr T* data() const noexcept { return data_; }
                   ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:743:44: error: no member named 'size' in namespace 'std::ranges'; did you mean simply 'size'?
                span(std::ranges::data(range), std::ranges::size(range))) {}
                                               ^~~~~~~~~~~~~~~~~
                                               size
    ../../third_party/mini_chromium/mini_chromium/base/compiler_specific.h:572:29: note: expanded from macro 'UNSAFE_BUFFERS'
    #define UNSAFE_BUFFERS(...) __VA_ARGS__
                                ^~~~~~~~~~~
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:884:20: note: 'size' declared here
      constexpr size_t size() const noexcept { return size_; }
                       ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:1045:42: error: no template named 'range_reference_t' in namespace 'std::ranges'; did you mean 'iter_reference_t'?
        typename T = std::remove_reference_t<std::ranges::range_reference_t<R>>>
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                             iter_reference_t
    ../../third_party/mini_chromium/mini_chromium/base/template_util.h:49:1: note: 'iter_reference_t' declared here
    using iter_reference_t = decltype(*std::declval<Iter&>());
    ^
    fatal error: too many errors emitted, stopping now [-ferror-limit=]
    20 errors generated.
    ninja: build stopped: subcommand failed.
    crashpad/cci.20240812: 
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    WARN: libcurl/8.10.1: requirement zlib/[>=1.2.11 <2] overridden by crashpad/cci.20240812 to zlib/1.3.1 
    WARN: openssl/3.3.2: requirement zlib/[>=1.2.11 <2] overridden by libcurl/8.10.1 to zlib/1.3.1 
    crashpad/cci.20240812: WARN: crashpad needs a shared libcurl library
    crashpad/cci.20240812: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    crashpad/cci.20240812: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    crashpad/cci.20240812: ERROR: Package 'dce385b01e75b0fd931ca02203b6b402d96ba28f' build failed
    crashpad/cci.20240812: WARN: Build folder /home/conan/workspace/prod-v1/bsr/113490/fedee/.conan/data/crashpad/cci.20240812/_/_/build/dce385b01e75b0fd931ca02203b6b402d96ba28f
    ERROR: crashpad/cci.20240812: Error in build() method, line 186
    	parallel=os.cpu_count()))
    	ConanException: Error 1 while executing ninja -C out/Default client minidump crashpad_handler snapshot -j4
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 5 (054d71bcbf4413a3e166a850d845fe35657b74a5):

  • crashpad/cci.20220219:
    Didn't run or was cancelled before finishing

  • crashpad/cci.20240812:
    CI failed to create some packages (All logs)

    Logs for packageID deb8b582999108e9603c0a08b3e086be1e194e7d:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=20
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
                                                      ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:48:32: note: declared here
    template <typename T, typename It>
                                   ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:50:26: error: use of address-of-label extension outside of a function body
                             LegalDataConversion<std::iter_reference_t<It>, T>;
                             ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:54:10: error: no member named 'ranges' in namespace 'std'
        std::ranges::contiguous_range<R> && std::ranges::sized_range<R> &&
        ~~~~~^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:54:35: error: 'R' does not refer to a value
        std::ranges::contiguous_range<R> && std::ranges::sized_range<R> &&
                                      ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:52:32: note: declared here
    template <typename T, typename R>
                                   ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:54:41: error: use of address-of-label extension outside of a function body
        std::ranges::contiguous_range<R> && std::ranges::sized_range<R> &&
                                            ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:65:11: error: no member named 'ranges' in namespace 'std'
      { *std::ranges::data(r) } -> LegalDataConversion<T>;
         ~~~~~^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:66:8: error: no member named 'ranges' in namespace 'std'
      std::ranges::size(r);
      ~~~~~^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:102:17: error: no member named 'equality_comparable_with' in namespace 'std'
               std::equality_comparable_with<T, U>)
               ~~~~~^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:102:42: error: 'T' does not refer to a value
               std::equality_comparable_with<T, U>)
                                             ^
    ../../third_party/mini_chromium/mini_chromium/base/containers/span.h:100:17: note: declared here
    template <class T, class U, size_t N, size_t M>
                    ^
    fatal error: too many errors emitted, stopping now [-ferror-limit=]
    20 errors generated.
    [5/239] CXX obj/third_party/mini_chromium/mini_chromium/base/strings/base.pattern.o
    [6/239] CXX obj/third_party/mini_chromium/mini_chromium/base/files/base.scoped_file.o
    [7/239] CXX obj/third_party/mini_chromium/mini_chromium/base/strings/base.stringprintf.o
    [8/239] CXX obj/third_party/mini_chromium/mini_chromium/base/files/base.file_path.o
    [9/239] CXX obj/third_party/mini_chromium/mini_chromium/base/strings/base.string_number_conversions.o
    [10/239] CXX obj/third_party/mini_chromium/mini_chromium/base/base.logging.o
    ninja: build stopped: subcommand failed.
    
    crashpad/cci.20240812: ERROR: 
    Package 'deb8b582999108e9603c0a08b3e086be1e194e7d' build failed
    crashpad/cci.20240812: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr/101352/babaf/p/b/crashcd42f1d33abaf/b
    ERROR: crashpad/cci.20240812: Error in build() method, line 186
    	parallel=os.cpu_count()))
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants