-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[level-zero] added new recipe #25068
Conversation
This comment has been minimized.
This comment has been minimized.
8153f72
to
37956b9
Compare
This comment has been minimized.
This comment has been minimized.
37956b9
to
a92f46b
Compare
This comment has been minimized.
This comment has been minimized.
a92f46b
to
016034e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
016034e
to
83d1fbc
Compare
This comment has been minimized.
This comment has been minimized.
83d1fbc
to
e5e71ac
Compare
This comment has been minimized.
This comment has been minimized.
e5e71ac
to
e6844f2
Compare
This comment has been minimized.
This comment has been minimized.
e6844f2
to
d746037
Compare
This comment has been minimized.
This comment has been minimized.
ddb5c44
to
e504721
Compare
This comment has been minimized.
This comment has been minimized.
e504721
to
87c79ad
Compare
This comment has been minimized.
This comment has been minimized.
87c79ad
to
0804808
Compare
This comment has been minimized.
This comment has been minimized.
0804808
to
6a22d6e
Compare
This comment has been minimized.
This comment has been minimized.
6a22d6e
to
d9ea346
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
0627b79
to
0226df5
Compare
This comment has been minimized.
This comment has been minimized.
recipes/level-zero/all/conanfile.py
Outdated
from conan.errors import ConanInvalidConfiguration | ||
from conan.tools.env import VirtualBuildEnv | ||
from conan.tools.cmake import CMakeToolchain, CMake, cmake_layout, CMakeDeps | ||
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches | |
from conan.tools.files import get, apply_conandata_patches, copy, export_conandata_patches, rmdir |
One more missing import. The last one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
c0f27d3
to
1c40c6d
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1c40c6dlevel-zero/1.17.39@#2f03801bd0294ffb7a82278d74ae003a
|
recipes/level-zero/all/conanfile.py
Outdated
env = VirtualBuildEnv(self) | ||
env.generate() | ||
apply_conandata_patches(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env = VirtualBuildEnv(self) | |
env.generate() | |
apply_conandata_patches(self) | |
apply_conandata_patches(self) |
- VirtualBuildEnv is not needed as there is no build requirement. Need to remove the import too, otherwise the linter will complain about
- apply_conandata_patches should be move to build(), so will touch only the build folder: https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L122 (do not need to add _patch_sources method, only move to build())
1c40c6d
to
fa5d5d7
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit fa5d5d7level-zero/1.17.39@#80a053d33412f60663cfe68e87f07ffc
|
recipes/level-zero/all/conanfile.py
Outdated
cmake_layout(self, src_folder="src") | ||
|
||
def generate(self): | ||
apply_conandata_patches(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apply_conandata_patches(self) |
I guess your last push missed it. Need to move the apply_conandata_patches
to build().
fa5d5d7
to
493ad5b
Compare
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 48 (
Conan v2 pipeline ✔️
All green in build 48 (
|
Hooks produced the following warnings for commit 493ad5blevel-zero/1.17.39@#97c1774d0c3a03d72ac71435cb8bcef7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Passed using the infrastructure 🎉 |
@jcar87 Could you please review? |
Sorry - it looks good! I've had a second pass since we now only support Conan 2 and also fixed (or appear to have fixed) the macOS support |
@RaguzovaTatyana your PR has been merged and now Level Zero is available in Conan Center: https://conan.io/center/recipes/level-zero?version=1.17.39. Thank you! |
Summary
Changes to recipe: level-zero/1.17.28
Motivation
Openvino recipe needs level-zero to support execution on Intel NPU devices
this library also might be used by libfabric
Details