Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readstat: add new recipe of readstat/1.1.9 #25181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shun2wang
Copy link

@shun2wang shun2wang commented Sep 8, 2024

Summary

Add recipe: readstat/1.1.9
https://github.com/WizardMac/ReadStat

Motivation

Add new library of readstat library to conancenter.

Details

ReadStat is a command-line tool (+ C library) for read/write and converting SAS, Stata, and SPSS files.


@CLAassistant
Copy link

CLAassistant commented Sep 8, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 9d8e100
readstat/1.1.9@#03433894a02e91a8905f7c92258410aa
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libreadstat.1.dylib, libreadstat.dylib

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 65 (f491eca89c32375477d81f107f9424e32340255b):

  • readstat/1.1.9:
    Error running command conan export recipes/readstat/all/conanfile.py readstat/1.1.9@:
    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 10.4013671875 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
    [HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
    [HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
    [HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
    [HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
    [HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
    [HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
    [HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
    [HOOK - conan-center.py] pre_export(): [PYLINT EXECUTION (KB-H072)] OK
    [HOOK - conan-center.py] pre_export(): [REQUIREMENT OVERRIDE PARAMETER (KB-H075)] OK
    [HOOK - conan-center.py] pre_export(): [NO DANGLING PATCHES (KB-H078)] OK
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    [HOOK - conan-center.py] pre_export(): ERROR: [NO BUILD SYSTEM FUNCTIONS (KB-H061)] /home/conan/workspace/prod-v1_cci_PR-25181/recipes/readstat/all/conanfile.py:88 Build system dependent functions detected. (Use of platform is forbidden in source) (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H061-NO-BUILD-SYSTEM-FUNCTIONS) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@uilianries
Copy link
Member

I would suggest keeping sources indexed by OS in conandata.yml instead. You can obtain several examples in CCI, for instance: https://github.com/conan-io/conan-center-index/blob/master/recipes/wasmtime/all/conandata.yml

@shun2wang shun2wang force-pushed the addReadstat branch 2 times, most recently from 5f5be3d to 6038915 Compare November 9, 2024 07:53
@shun2wang
Copy link
Author

NEED HELP:

Anyone can help me to build it on Windows? with thanks.

@shun2wang shun2wang requested a review from uilianries November 9, 2024 07:54
@shun2wang
Copy link
Author

Hi @uilianries Could you please help me with it? with thanks.

@uilianries
Copy link
Member

@shun2wang Unfortunately I have no access to Windows machine right now, but I'll have by this week. I'll be back to this PR this week.

@uilianries uilianries self-assigned this Nov 26, 2024
@uilianries
Copy link
Member

@shun2wang I tried to build Readstat on Windows but it failed as well and looks be a lack of support from the upstream.

Their CI is configured only for mingw on Windows: https://github.com/WizardMac/ReadStat/blob/dev/.github/workflows/build.yml

The MSVC project file supported there is old, and will need patch to work as well.

Are you really using Readstat on Windows? If Yes, how did you build it? In case you could not build locally, I would suggest only supporting Linux and Mac for now.

You could ask for CMake support to the upstream, I believe it could not fix the Windows build, but give better Linux support as well.

@shun2wang
Copy link
Author

shun2wang commented Nov 27, 2024

Are you really using Readstat on Windows?

Yes, I build it by msys2 env (not nmake or VS) on my local. I actually only want to use this on Windows and Mac, and you know Linux builds are quite easy

@shun2wang
Copy link
Author

Is there a way in conan to build these libraries for Windows using the msys environment?

@uilianries
Copy link
Member

Is there a way in conan to build these libraries for Windows using the msys environment?

@shun2wang Yes, please read #26024 (comment)

Both ReadStat and libRdata look be in the same case. You could try the same approach for both packages. Tell me if you can not configure your recipe to work with MSYS2. Regards.

@shun2wang
Copy link
Author

Both ReadStat and libRdata look be in the same case. You could try the same approach for both packages. Tell me if you can not configure your recipe to work with MSYS2.

Yes, I tried many many times for build with MSYS2 but failed, please help me. with thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants