-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fenster: new recipe #25186
base: master
Are you sure you want to change the base?
fenster: new recipe #25186
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Minor comment, otherwise looks good
recipes/fenster/all/conanfile.py
Outdated
self.cpp_info.requires.append("xorg::x11") | ||
# Also has an optional dependency on "asound" if fenster_audio.h is used. | ||
# It can be provided either as a system lib or via libalsa Conan package. | ||
# I'll leave it for the consumer to handle to keep the recipe simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this really complicate the recipe that much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK, I though you guys hated recipe options that are avoidable: #22290 (comment)
Anyway, I added enable_graphics
and enable_audio
options, since that enables the lists of required system libs to be kept more focused as well.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
|
Summary
Changes to recipe: fenster/0.0.0.cci.20240909
Motivation
Adds fenster: The most minimal cross-platform GUI library
https://github.com/zserge/fenster
Details
/cc @zserge