libelf: fix build failure using mingw #25276

joda01 · 2024-09-15T18:40:53Z

Fixed missing include which allows to use getenv

Summary

Changes to recipe: lib/0.8.13

Motivation

Fix build error with mingw under Windows

C:\J\workspace\cci_mirror_PR-127\conan-home\p\b\libelecbadf08d4c97\b\src\lib\version.c: In function 'elf_version':
C:\J\workspace\cci_mirror_PR-127\conan-home\p\b\libelecbadf08d4c97\b\src\lib\version.c:31:14: error: implicit declaration of function 'getenv' [-Wimplicit-function-declaration]
   31 |     if ((s = getenv("LIBELF_SANITY_CHECKS"))) {
      |              ^~~~~~
C:\J\workspace\cci_mirror_PR-127\conan-home\p\b\libelecbadf08d4c97\b\src\lib\version.c:21:1: note: 'getenv' is defined in header '<stdlib.h>'; this is probably fixable by adding '#include <stdlib.h>'
   20 | #include <private.h>
  +++ |+#include <stdlib.h>
   21 | 
C:\J\workspace\cci_mirror_PR-127\conan-home\p\b\libelecbadf08d4c97\b\src\lib\version.c:31:12: error: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   31 |     if ((s = getenv("LIBELF_SANITY_CHECKS"))) {
      |            ^
C:\J\workspace\cci_mirror_PR-127\conan-home\p\b\libelecbadf08d4c97\b\src\lib\version.c:32:35: error: implicit declaration of function 'strtol'; did you mean 'strtok'? [-Wimplicit-function-declaration]
   32 |         _elf_sanity_checks = (int)strtol(s, (char**)NULL, 0);
      |                                   ^~~~~~
      |                                   strtok
mingw32-make[2]: *** [CMakeFiles\elf.dir\build.make:841: CMakeFiles/elf.dir/src/lib/version.c.obj] Error 1

Details

Added patch which adds #include <stdlib.h>

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

CLAassistant · 2024-09-15T18:40:59Z

All committers have signed the CLA.

joda01 · 2024-09-15T18:41:12Z

Relates to #25275

recipes/libelf/all/conanfile.py

SpaceIm · 2024-09-15T20:26:05Z

Please consider joda01#1

uilianries · 2024-09-16T13:20:21Z

@joda01 Thank you for your PR! Please, comment on the issue #4 to be able to run your PR in the CI as well.

AbrilRBS · 2024-09-20T19:17:52Z

@joda01 please take a look into @SpaceIm PR, it's a better way to implement patches.

I do have a question: Has this issue been reported tp upstream? I'm sure they'd appreciate getting a heads-up!

joda01 · 2024-09-20T20:43:58Z

@AbrilRBS Was this what you meant with better way to provide a patch?
https://github.com/conan-io/conan-center-index/pull/25276/files

When you say 'upstream', do you mean https://directory.fsf.org/wiki/Libelf?

I'm curious if anyone else has encountered similar build issues when using MingW?

conan-center-bot · 2024-09-30T21:08:09Z

Conan v1 pipeline ❌

Failure in build 9 (1c0146bf70df72e4182599b60ccd5d3d422f82b7):

libelf/0.8.13:
CI failed to create some packages (All logs)

Logs for packageID 3fb49604f9c2f729b85ba3115852006824e72cab:

[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
[options]
libelf:shared=False

[...]
  version.c
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\opt.delscn.c(97,50): warning C4267: '=': conversion from 'size_t' to 'Elf64_Word', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
  x.elfext.c
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(161,30): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
  x.movscn.c
  x.remscn.c
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(166,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(89,14): error C2375: 'free': redefinition; different linkage (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\private.h(45): message : see declaration of 'free' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(190,5): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\x.elfext.c(169,48): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(101,15): error C2375: 'malloc': redefinition; different linkage (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\private.h(44): message : see declaration of 'malloc' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\x.elfext.c(170,34): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(227,3): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(115,1): warning C4003: not enough arguments for function-like macro invocation '_msize' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\x.elfext.c(174,48): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(233,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(115,1): error C2059: syntax error: '(' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\x.elfext.c(175,34): warning C4267: '=': conversion from 'size_t' to 'Elf64_Word', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(235,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(126,15): error C2375: 'realloc': redefinition; different linkage (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\private.h(44): message : see declaration of 'realloc' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(284,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\stdlib.h(60,48): error C2375: 'abort': redefinition; different linkage (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\private.h(45): message : see declaration of 'abort' (compiling source file C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c) [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(307,5): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(320,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\version.c(32,14): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(357,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(363,30): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(393,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(510,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(523,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(755,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(882,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(893,41): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(893,6): warning C4996: 'write': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _write. See online help for details. [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\src\lib\update.c(955,6): warning C4996: 'lseek': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _lseek. See online help for details. [C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build\elf.vcxproj]
libelf/0.8.13: 
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
libelf/0.8.13: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
libelf/0.8.13: ERROR: Package '3fb49604f9c2f729b85ba3115852006824e72cab' build failed
libelf/0.8.13: WARN: Build folder C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build
ERROR: libelf/0.8.13: Error in build() method, line 90
	cmake.build()
	ConanException: Error 1 while executing cmake --build "C:\J\workspace\prod-v1\bsr@2\104456\ebabd\.conan\data\libelf\0.8.13\_\_\build\3fb49604f9c2f729b85ba3115852006824e72cab\build" --config Release

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 9 (1c0146bf70df72e4182599b60ccd5d3d422f82b7):

libelf/0.8.13:
CI failed to create some packages (All logs)

Logs for packageID 41ad450120fdab2266b1185a967d298f7ae52595:

[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=192
os=Windows
[options]
*/*:shared=False

[...]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\opt.delscn.c(80,50): warning C4267: '=': conversion from 'size_t' to 'Elf64_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
  verdef_64_tof.c
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\opt.delscn.c(97,50): warning C4267: '=': conversion from 'size_t' to 'Elf64_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(155,5): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
  verdef_64_tom.c
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(161,30): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(166,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(190,5): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
  version.c
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(227,3): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
  x.elfext.c
  x.movscn.c
  x.remscn.c
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(89,14): error C2375: 'free': redefinition; different linkage (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\private.h(45): message : see declaration of 'free' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(233,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\x.elfext.c(169,48): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(101,15): error C2375: 'malloc': redefinition; different linkage (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\private.h(44): message : see declaration of 'malloc' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(235,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\x.elfext.c(170,34): warning C4267: '=': conversion from 'size_t' to 'Elf32_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(115,1): warning C4003: not enough arguments for function-like macro invocation '_msize' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(284,6): warning C4267: '=': conversion from 'size_t' to 'Elf32_Off', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\x.elfext.c(174,48): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(115,1): error C2059: syntax error: '(' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(307,5): warning C4267: '=': conversion from 'size_t' to 'Elf32_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\x.elfext.c(175,34): warning C4267: '=': conversion from 'size_t' to 'Elf64_Word', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\corecrt_malloc.h(126,15): error C2375: 'realloc': redefinition; different linkage (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\private.h(44): message : see declaration of 'realloc' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(320,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.20348.0\ucrt\stdlib.h(60,48): error C2375: 'abort': redefinition; different linkage (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\private.h(45): message : see declaration of 'abort' (compiling source file C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c) [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(357,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\version.c(32,14): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(363,30): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(393,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(510,5): warning C4267: '=': conversion from 'size_t' to 'Elf64_Half', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(523,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(755,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(882,15): warning C4267: 'return': conversion from 'size_t' to 'off_t', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(893,41): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(893,6): warning C4996: 'write': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _write. See online help for details. [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]
C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\src\lib\update.c(955,6): warning C4996: 'lseek': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _lseek. See online help for details. [C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build\elf.vcxproj]

libelf/0.8.13: ERROR: 
Package '41ad450120fdab2266b1185a967d298f7ae52595' build failed
libelf/0.8.13: WARN: Build folder C:\J\workspace\prod-v2\bsr@3\93250\eaefd\p\b\libelb1a99943323b4\b\build
ERROR: libelf/0.8.13: Error in build() method, line 90
	cmake.build()
	ConanException: Error 1 while executing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

…package

jcar87 · 2024-12-06T15:49:25Z

Thanks @joda01 for reporting this. I've amended the PR description with a copy of the actual compilation error, for traceability and in case its useful to others.

With your proposed fix of added the missing include, that broke the build with MSVC - but fixed it with gcc/mingw. Looking further into it, it shouldn't have been necessary to include stdlib.h - as that should've been handled by the config.h - which shouldve already been including it (via private.h). Turns out that there was a bug in the Conan Center specific CMakeLists.txt - I've fixed that and now it should work for both msvc and mingw.

I've enabled a mingw build for this PR, results here: https://github.com/conan-io/conan-center-index/pull/25276/checks?check_run_id=34040477957 - as evidence this fixes your issue :)

Thanks for contributing to Conan Center!

* libelf: fix missing inclusion of config.h on windows, remove test_v1_package * Assume settings_build is defined --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>

conan-center-bot added the User-approval pending label Sep 15, 2024

This comment has been minimized.

Sign in to view

SpaceIm reviewed Sep 15, 2024

View reviewed changes

recipes/libelf/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

uilianries mentioned this pull request Sep 20, 2024

[bot] Update authorized users list (2024-09-19) #25324

Merged

joda01 mentioned this pull request Sep 20, 2024

[!!] Access request #4

Closed

AbrilRBS self-assigned this Sep 20, 2024

conan-center-bot removed the User-approval pending label Sep 20, 2024

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 30, 2024

This comment has been minimized.

Sign in to view

jcar87 changed the title ~~fix: build failure using mingw~~ libelf: fix build failure using mingw Dec 6, 2024

libelf: fix missing inclusion of config.h on windows, remove test_v1_…

1efdb6c

…package

jcar87 force-pushed the package/libelf branch from 1c0146b to 1efdb6c Compare December 6, 2024 15:30

Assume settings_build is defined

79e5452

jcar87 approved these changes Dec 6, 2024

View reviewed changes

jcar87 merged commit 37116e6 into conan-io:master Dec 6, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libelf: fix build failure using mingw #25276

libelf: fix build failure using mingw #25276

joda01 commented Sep 15, 2024 •

edited by jcar87

Loading

CLAassistant commented Sep 15, 2024 •

edited

Loading

joda01 commented Sep 15, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Sep 15, 2024

uilianries commented Sep 16, 2024

AbrilRBS commented Sep 20, 2024

joda01 commented Sep 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Sep 30, 2024

jcar87 commented Dec 6, 2024

libelf: fix build failure using mingw #25276

libelf: fix build failure using mingw #25276

Conversation

joda01 commented Sep 15, 2024 • edited by jcar87 Loading

Summary

Motivation

Details

CLAassistant commented Sep 15, 2024 • edited Loading

joda01 commented Sep 15, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Sep 15, 2024

uilianries commented Sep 16, 2024

AbrilRBS commented Sep 20, 2024

joda01 commented Sep 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Sep 30, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

jcar87 commented Dec 6, 2024

joda01 commented Sep 15, 2024 •

edited by jcar87

Loading

CLAassistant commented Sep 15, 2024 •

edited

Loading