Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo: Fix alloca issue in MSVC cairo #25345

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Sep 20, 2024

Summary

Changes to recipe: cairo/[1.18]

Motivation

Couldn't compile on my local MSVC setup, but it's interesting to note that the CI did not have the same issue.

This patch is present in most other package managers, seems like we added the version too soon to catch it

Details

Before:

[150/151] Linking target util/cairo-script/csi-exec.exe
FAILED: util/cairo-script/csi-exec.exe
"link"  /MACHINE:x64 /OUT:util/cairo-script/csi-exec.exe util/cairo-script/csi-exec.exe.p/csi-exec.c.obj "/release" "/nologo" "/OPT:REF" "src/libcairo.a" "util/cairo-script/libcairo-script-interpreter.a" "C:/Users/abril/.conan2/p/zlib6f797a4dd16fb/p/lib/zlib.lib" "C:/Users/abril/.conan2/p/libpn214f4edd5a70e/p/lib/libpng16_static.lib" "C:/Users/abril/.conan2/p/fontc74b173433a2a8/p/lib/fontconfig.lib" "C:/Users/abril/.conan2/p/b/freet8f053502a46c4/p/lib/freetype.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlidec.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlienc.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlicommon.lib" "C:/Users/abril/.conan2/p/bzip2e06444d88ab4f/p/lib/bz2.lib" "C:/Users/abril/.conan2/p/expatc090f2293063f/p/lib/libexpatMD.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "C:/Users/abril/.conan2/p/pixmae425c2c5d0971/p/lib/libpixman-1.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "C:/Users/abril/.conan2/p/lzoaeba5eb052ec5/p/lib/lzo2.lib" "/SUBSYSTEM:CONSOLE" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
   Creando biblioteca util\cairo-script\csi-exec.lib y objeto util\cairo-script\csi-exec.exp
libcairo.a(cairo-colr-glyph-render.c.obj) : error LNK2019: símbolo externo alloca sin resolver al que se hace referencia en la función add_sweep_gradient_patches
util\cairo-script\csi-exec.exe : fatal error LNK1120: 1 externos sin resolver
[151/151] Linking target util/cairo-script/csi-replay.exe
FAILED: util/cairo-script/csi-replay.exe
"link"  /MACHINE:x64 /OUT:util/cairo-script/csi-replay.exe util/cairo-script/csi-replay.exe.p/csi-replay.c.obj "/release" "/nologo" "/OPT:REF" "src/libcairo.a" "util/cairo-script/libcairo-script-interpreter.a" "C:/Users/abril/.conan2/p/zlib6f797a4dd16fb/p/lib/zlib.lib" "C:/Users/abril/.conan2/p/libpn214f4edd5a70e/p/lib/libpng16_static.lib" "C:/Users/abril/.conan2/p/fontc74b173433a2a8/p/lib/fontconfig.lib" "C:/Users/abril/.conan2/p/b/freet8f053502a46c4/p/lib/freetype.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlidec.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlienc.lib" "C:/Users/abril/.conan2/p/brotl79757a5cae055/p/lib/brotlicommon.lib" "C:/Users/abril/.conan2/p/bzip2e06444d88ab4f/p/lib/bz2.lib" "C:/Users/abril/.conan2/p/expatc090f2293063f/p/lib/libexpatMD.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "C:/Users/abril/.conan2/p/pixmae425c2c5d0971/p/lib/libpixman-1.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "C:/Users/abril/.conan2/p/lzoaeba5eb052ec5/p/lib/lzo2.lib" "/SUBSYSTEM:CONSOLE" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
   Creando biblioteca util\cairo-script\csi-replay.lib y objeto util\cairo-script\csi-replay.exp
libcairo.a(cairo-colr-glyph-render.c.obj) : error LNK2019: símbolo externo alloca sin resolver al que se hace referencia en la función add_sweep_gradient_patches
util\cairo-script\csi-replay.exe : fatal error LNK1120: 1 externos sin resolver
ninja: build stopped: subcommand failed.

After: It compiles


@AbrilRBS AbrilRBS self-assigned this Sep 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (cabd06e62f0f6a4f31343ecc82679a71d0eac876):

  • cairo/1.17.8:
    Built 10 packages out of 22 (All logs)

  • cairo/1.17.4:
    Built 10 packages out of 22 (All logs)

  • cairo/1.17.6:
    Built 10 packages out of 22 (All logs)

  • cairo/1.18.0:
    Built 10 packages out of 22 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c2c5964 into conan-io:master Sep 20, 2024
22 checks passed
@AbrilRBS AbrilRBS deleted the ar/cairo-alloca-fix branch September 20, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants