Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packio: migrate to Conan v2, drop old versions #25392

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 24, 2024

Summary

Changes to recipe: packo/[*]

Motivation

Details

Continues from #16876 by @SpaceIm.

I dropped even more versions - everything up to v2.1.0, which was released in late 2020. This allowed the recipe to be cleaned up significantly by dropping the exceptions needed by the old versions.


@conan-center-bot conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Sep 24, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Service Under Maintenance and removed Failed Version conflict There is a version conflict when solving the dependencies graph labels Sep 25, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think removing older versions is a good call. I have one minor question before approving, otherwise looks good

if self.options.nlohmann_json:
self.requires("nlohmann_json/3.11.3")
if self._use_boost_json or not self.options.standalone_asio:
self.requires("boost/1.83.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are newer versions not compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It avoids a conflict with boost/1.83.0 in msgpack-cxx. It built fine with Boost 1.85.0 otherwise.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (cf8a721914da7319cc95bdc3c0bd564ae129b69f):

  • packio/2.5.0:
    Built 5 packages out of 11 (All logs)

  • packio/2.3.0:
    Built 5 packages out of 11 (All logs)

  • packio/2.4.1:
    Built 5 packages out of 11 (All logs)

  • packio/2.2.0:
    Built 5 packages out of 11 (All logs)

  • packio/2.1.0:
    Built 5 packages out of 11 (All logs)

@valgur valgur requested a review from AbrilRBS September 26, 2024 12:12
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants