-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packio: migrate to Conan v2, drop old versions #25392
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think removing older versions is a good call. I have one minor question before approving, otherwise looks good
if self.options.nlohmann_json: | ||
self.requires("nlohmann_json/3.11.3") | ||
if self._use_boost_json or not self.options.standalone_asio: | ||
self.requires("boost/1.83.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are newer versions not compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It avoids a conflict with boost/1.83.0
in msgpack-cxx
. It built fine with Boost 1.85.0 otherwise.
Conan v1 pipeline ✔️All green in build 3 ( |
Summary
Changes to recipe: packo/[*]
Motivation
Details
Continues from #16876 by @SpaceIm.
I dropped even more versions - everything up to v2.1.0, which was released in late 2020. This allowed the recipe to be cleaned up significantly by dropping the exceptions needed by the old versions.