Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oatpp-websocket: add package_type, transitive_headers=True #25403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 25, 2024

Summary

Changes to recipe: lib/[version]

Motivation

Details


@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Sep 25, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, a small comment justifying the traits would be appreciated for future maintenability before merging this, thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (acaab3b155224a1e20cfd9d1a06a288e98a4735c):

  • oatpp-websocket/1.3.0:
    Built 20 packages out of 22 (All logs)

  • oatpp-websocket/1.2.0:
    Built 20 packages out of 22 (All logs)

  • oatpp-websocket/1.0.0:
    Built 20 packages out of 22 (All logs)

  • oatpp-websocket/1.2.5:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (acaab3b155224a1e20cfd9d1a06a288e98a4735c):

  • oatpp-websocket/1.2.0:
    Built 8 packages out of 10 (All logs)

  • oatpp-websocket/1.3.0:
    Built 8 packages out of 10 (All logs)

  • oatpp-websocket/1.0.0:
    Built 8 packages out of 10 (All logs)

  • oatpp-websocket/1.2.5:
    Built 8 packages out of 10 (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit acaab3b
oatpp-websocket/1.3.0@#404fd2c3ebf590c2d0bd15c5726cbe87
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.3.0/liboatpp-websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.
oatpp-websocket/1.2.0@#dd19c7b3a3ddcca60ee9b49a91f7db58
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.0/liboatpp-websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.
oatpp-websocket/1.0.0@#0056a027ec0b4e073dc20ff72c64789d
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.0.0/liboatpp-websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.
oatpp-websocket/1.2.5@#a4da914e29cf3bc9c54f540d85d4a985
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.5/liboatpp-websocket.so' links to system library 'm' but it is not in cpp_info.system_libs.

@AbrilRBS
Copy link
Member

@valgur feel free to address the hook warning, thanks!

@valgur
Copy link
Contributor Author

valgur commented Sep 26, 2024

@AbrilRBS Eh, libm has been bundled into libc for years now. I don't see much point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants