-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qxlsx] Use version range for Qt #25422
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Failed test package on Conan 2.x because could not find QBuffer header. I gonna fix it. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
INFO: f1395ec The QxLSX uses Qt headers in its public headers. So we need to use transitive headers. I also reduced the test package to only validate the linkage. It would fail, as there is no file to be read. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
When building on Windows I was capable to use all shared for 1.4.4, but it's working on 1.4.5. I can see several changes regarding cmake between these patch versions: QtExcel/QXlsx@v1.4.4...v1.4.5#diff-4398dbc03cadbd80eb990f0a3270e8443a672991d8c0113be77afca953bd9cec As result, I excluded 1.4.4. The CMake target and file name are not related to core, but the project name itself: |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
The version 1.4.5 produces the cmake file |
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Changes to recipe: qxlsx/1.4.5
Motivation
The maintained version of Qt-5 is 5.15.14, resulting in missing binary packages when building this package. Using version ranges for Qt solves the current error.
Details
Plus, dropped support for version 1.4.3. There is no other recipe consuming qxlsx in CCI.
The version 1.4.3 is not listed in issues: https://github.com/conan-io/conan-center-index/issues?q=is%3Aissue+qxlsx
And, it's a release from 2021, where the latest version (1.4.9) is from 2024: https://github.com/QtExcel/QXlsx/releases