Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qxlsx] Use version range for Qt #25422

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Sep 26, 2024

Summary

Changes to recipe: qxlsx/1.4.5

Motivation

The maintained version of Qt-5 is 5.15.14, resulting in missing binary packages when building this package. Using version ranges for Qt solves the current error.

Details

Plus, dropped support for version 1.4.3. There is no other recipe consuming qxlsx in CCI.

The version 1.4.3 is not listed in issues: https://github.com/conan-io/conan-center-index/issues?q=is%3Aissue+qxlsx

And, it's a release from 2021, where the latest version (1.4.9) is from 2024: https://github.com/QtExcel/QXlsx/releases


Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries self-assigned this Sep 26, 2024
AbrilRBS
AbrilRBS previously approved these changes Sep 26, 2024
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member Author

Failed test package on Conan 2.x because could not find QBuffer header. I gonna fix it.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member Author

INFO: f1395ec

The QxLSX uses Qt headers in its public headers. So we need to use transitive headers.

I also reduced the test package to only validate the linkage. It would fail, as there is no file to be read.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Sep 26, 2024

Signed-off-by: Uilian Ries <uilianries@gmail.com>
AbrilRBS
AbrilRBS previously approved these changes Sep 26, 2024
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

When building on Windows I was capable to use all shared for 1.4.4, but it's working on 1.4.5. I can see several changes regarding cmake between these patch versions: QtExcel/QXlsx@v1.4.4...v1.4.5#diff-4398dbc03cadbd80eb990f0a3270e8443a672991d8c0113be77afca953bd9cec

As result, I excluded 1.4.4.

The CMake target and file name are not related to core, but the project name itself:

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Sep 26, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

The version 1.4.5 produces the cmake file QXlsxQt5Config.cmake (or 6), with the target QXlsx::QXlsx. I dropped test v1 package as it failing due limitation of cmake_find_package in creating using a different namespace.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (a5ea3155e41ba2d929dc874e9f883ed52ebbaa48):

  • qxlsx/1.4.5:
    All packages built successfully! (All logs)

  • qxlsx/1.4.4:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (a5ea3155e41ba2d929dc874e9f883ed52ebbaa48):

  • qxlsx/1.4.5:
    Built 8 packages out of 10 (All logs)

  • qxlsx/1.4.4:
    Built 6 packages out of 10 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3b487a8 into conan-io:master Oct 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants