libpq: add v17.0 using the new Meson build system #25458
+525
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
jwillikers
approved these changes
Oct 7, 2024
|
|
||
| def _fix_static_library_names(self): | ||
| # Meson outputs static libraries with a .a extension on Windows, | ||
| # which is not compatible with Conan and CMake. |
There was a problem hiding this comment.
Fyi, newer CMake versions, 3.29 and later, support .a file extensions for static libraries on Windows when building with MSVC. See the release notes here.
It would be nice to see support for using the .a suffixes eventually. I think Meson made the right decision to use .a instead of .lib on Windows for static libraries to avoid confusion with import libraries which use the same .lib extension.
TibiIius
added a commit
to dampsoft/conan-center-index
that referenced
this pull request
Nov 29, 2024
- use Meson build system in favour of Autotools Source: conan-io#25458
valgur
force-pushed
the
update/libpq-meson
branch
from
afd7254 to
d3f8fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libpq/17.0
Motivation
Switching to the new Meson-based build system to hopefully get rid of the maintenance overhead of the large number of complex patches and additional installation steps required in the Autotools-based recipe.
See the original commit in the repo for more context: postgres/postgres@e692727
Details
Added nearly all supported external dependencies as options. Some of them are only used by the server executable, which is out of scope for the recipe, but I decided to keep them since the building of executables cannot be disabled, so might as well keep the server and other executables in the package as an option.
These PRs are required for optional dependencies: