fix: Added mingw patch

[joda01]

Summary

Changes to recipe: onnx/1.16.2

Motivation

See #25468

Details

I added #undef OPTIONAL to the lib header which undefs the predefined macro from windows.h.

---

• Read the contributing guidelines
• Checked that this PR is not a duplicate: list of PRs by recipe
• Tested locally with at least one configuration using a recent version of Conan

[conan-center-bot]

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (9bdb85e4d65b0006432886ab78dc1537dab69277):

• onnx/1.14.1:
  Built 20 packages out of 22 (All logs)

• onnx/1.16.0:
  Built 16 packages out of 22 (All logs)

• onnx/1.15.0:
  Built 18 packages out of 22 (All logs)

• onnx/1.14.0:
  Built 20 packages out of 22 (All logs)

• onnx/1.16.2:
  Built 16 packages out of 22 (All logs)

• onnx/1.17.0:
  Built 16 packages out of 22 (All logs)

• onnx/1.13.1:
  Built 20 packages out of 22 (All logs)

• onnx/1.16.1:
  Built 16 packages out of 22 (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (9bdb85e4d65b0006432886ab78dc1537dab69277):

• onnx/1.16.1:
  All packages built successfully! (All logs)

• onnx/1.14.0:
  All packages built successfully! (All logs)

• onnx/1.15.0:
  All packages built successfully! (All logs)

• onnx/1.16.0:
  All packages built successfully! (All logs)

• onnx/1.16.2:
  All packages built successfully! (All logs)

• onnx/1.14.1:
  All packages built successfully! (All logs)

• onnx/1.13.1:
  All packages built successfully! (All logs)

[AbrilRBS]

Hi @joda01 thanks a lot for your contribution. I'd like to understand if this issue has been reported to onnx, I'm sure they'd appreciate having this info - Do you have any insight into the status of this issue there? Thanks!

[joda01]

Hi @joda01 thanks a lot for your contribution. I'd like to understand if this issue has been reported to onnx, I'm sure they'd appreciate having this info - Do you have any insight into the status of this issue there? Thanks!

Hi @AbrilRBS I reported the issue to onnx/onnx. Relates to onnx/onnx#6506
and there was a similar issue from 2018 see onnx/onnx#1065

[danimtb]

Hi @joda01:

I have tested the different versions, and at least from version 1.15.0, the same error still happens. If we are going to add this patch, it should be applied there as well.

Regarding the patch, I think this is the less intrusive approach and the easiest to understand, although I hope it gets resolved upstream at some point.

[joda01]

Hi @danimtb !

Thanks for your review. What do you think is the best way to add the patch for all versions? Should I add a separate entry in the yaml for each affected version?

[danimtb]

@joda01 having a look again I realized the patches are very much specific for MinGW (we try to keep the patches as much generic as possible)

In that case, I am a bit hesitant now as the patch may cause any unknown side-effect on other Windows compilations.

I believe this exceeds our responsibility here and will require advice from someone on the onnx project on how to handle MinGW builds, maybe we can follow-up up onnx/onnx#6506 when they get back to you. I'm sorry about the confusion.

[AbrilRBS]

Note that you might be able to solve this on your end by adding

[conf]
onnx/*:tools.build:defines=["OPTIONAL=OPTIONAL"]

to your profile, which will ensure that the optional macro is not defined by Windows, and will allow the Onnx build to proceed