[zulu-openjdk] Bugfixes for the Zulu JDK package #25485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit 5061f16zulu-openjdk/11.0.24@#4879f535c336c9c84ecd8b13e95c3538zulu-openjdk/21.0.4@#7507846af1f702153594a14a1996b509zulu-openjdk/11.0.12@#31ee00f80e81df1d11261f88469f5666zulu-openjdk/11.0.19@#47151ecebf84c4fa99443024a848f203zulu-openjdk/17.0.9@#a5113261164e089bafb13e65f917af94zulu-openjdk/21.0.1@#5daf6540dffee73b8d1df140f133bfb2zulu-openjdk/11.0.15@#8dd715e558a916d85a8f64b302e6195b |
|
We have had this in production for a while using Conan 1.64.1, so we have confidence in the recipe changes here. |
valgur
reviewed
Dec 10, 2024
Recently the Zulu package was enhance by adding many different binaries for version 11.0.24. However, other changes to support these binary packages should also have been made at that time, as none of them were functional. host settings should identfy the binary type of the package: conan-io#25484 validation should support all the new configurations: conan-io#25483 Zip files with executables need an extra flag: conan-io#25482
eliminate compiler and build_type settings from the list.
datalogics-robb
force-pushed
the
zulu-bugfixes
branch
from
5061f16 to
65d1e5a
Compare
valgur
reviewed
Dec 13, 2024
| @property | ||
| def _settings_build(self): | ||
| return getattr(self, "settings_build", self.settings) | ||
| settings = "os", "arch" |
There was a problem hiding this comment.
Suggested change
| settings = "os", "arch" | |
| settings = "os", "arch", "compiler", "build_type" |
Keep the original settings.
There was a problem hiding this comment.
@valgur can you comment as to why we'd keep the settings here? My thinking is that we don't use a compiler, so we don't need its settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the Zulu package was enhanced by adding additional binaries for version 11.0.24.
However, other changes to support these binary packages should also have been made at that time, as none of them were functional.
This pull request resolves three of these problems and has been tested on these platforms.
Summary
Changes to recipe: zulu-openjdk/11.0.24
Motivation
host settings should identfy the binary type of the package:
#25484
validation should support all the new configurations:
#25483
Zip files with executables need an extra flag:
#25482
Details
keep_permissions=Truefor theget()tool