Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatbuffers: version 1.12.0: build bugfix #25607

Merged
merged 9 commits into from
Nov 11, 2024
Merged

flatbuffers: version 1.12.0: build bugfix #25607

merged 9 commits into from
Nov 11, 2024

Conversation

HazyMrf
Copy link
Contributor

@HazyMrf HazyMrf commented Oct 12, 2024 •
edited
Loading

Summary

Changes to recipe: flatbuffers[1.12.0]

Motivation

Closes #25601

Details

Fixes google/flatbuffers#6036 bug for Conan Package

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@HazyMrf HazyMrf mentioned this pull request Oct 12, 2024
Closed
@HazyMrf HazyMrf changed the title BugFix for flatbuffers/1.12.0 flatbuffers: version 1.12.0 bugfix Oct 14, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
1 similar comment
@conan-center-bot

This comment has been minimized.

Sign in to view
@HazyMrf HazyMrf changed the title flatbuffers: version 1.12.0 bugfix flatbuffers: version 1.12.0: build bugfix Oct 14, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@HazyMrf
Copy link
Contributor Author

HazyMrf commented Oct 15, 2024

Yo, thanks for granting access to PRs. As you see all pipelines passed, I just wait for your approval.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (ceed9f06153e853f713edba3b88d37893ac662f8):

  • flatbuffers/22.9.29:
    All packages built successfully! (All logs)

  • flatbuffers/24.3.7:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.8:
    All packages built successfully! (All logs)

  • flatbuffers/23.5.26:
    All packages built successfully! (All logs)

  • flatbuffers/1.12.0:
    All packages built successfully! (All logs)

  • flatbuffers/24.3.25:
    All packages built successfully! (All logs)

  • flatbuffers/23.1.4:
    All packages built successfully! (All logs)

  • flatbuffers/23.3.3:
    All packages built successfully! (All logs)

  • flatbuffers/22.11.23:
    All packages built successfully! (All logs)

  • flatbuffers/22.10.26:
    All packages built successfully! (All logs)

  • flatbuffers/23.1.21:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.6:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.5:
    All packages built successfully! (All logs)

  • flatbuffers/22.12.06:
    All packages built successfully! (All logs)

  • flatbuffers/22.9.24:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (ceed9f06153e853f713edba3b88d37893ac662f8):

  • flatbuffers/24.3.7:
    All packages built successfully! (All logs)

  • flatbuffers/23.3.3:
    All packages built successfully! (All logs)

  • flatbuffers/24.3.25:
    All packages built successfully! (All logs)

  • flatbuffers/23.1.21:
    All packages built successfully! (All logs)

  • flatbuffers/23.1.4:
    All packages built successfully! (All logs)

  • flatbuffers/22.12.06:
    All packages built successfully! (All logs)

  • flatbuffers/22.10.26:
    All packages built successfully! (All logs)

  • flatbuffers/23.5.26:
    All packages built successfully! (All logs)

  • flatbuffers/22.9.29:
    All packages built successfully! (All logs)

  • flatbuffers/22.11.23:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.8:
    All packages built successfully! (All logs)

  • flatbuffers/22.9.24:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.6:
    All packages built successfully! (All logs)

  • flatbuffers/2.0.5:
    All packages built successfully! (All logs)

  • flatbuffers/1.12.0:
    All packages built successfully! (All logs)

valgur
valgur approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HazyMrf
Copy link
Contributor Author

HazyMrf commented Oct 16, 2024

One more approval left! @AbrilRBS , maybe you can review this small PR?

@AbrilRBS AbrilRBS self-assigned this Oct 17, 2024
AbrilRBS
AbrilRBS approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

perseoGI
perseoGI approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see conan v1 removals!

@AbrilRBS AbrilRBS merged commit 89970d5 into conan-io:master Nov 11, 2024
9 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
@HazyMrf @jcar87
@AbrilRBS @OMGtechy
flatbuffers: version 1.12.0: build bugfix (conan-io#25607)
6311851 
Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valgur valgur valgur approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@perseoGI perseoGI perseoGI approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@HazyMrf @CLAassistant @conan-center-bot @valgur @AbrilRBS @perseoGI @jcar87