-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keystone: add new recipe #25968
keystone: add new recipe #25968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luadebug Thank you for your PR! I did a review over your contribution, please take a look on my suggestions.
A consideration: The keystone library is C++, not C. The application ktool is C. As we mainly are focused on libraries, the C++ settings should be preserved. (Unless the library has C interface only).
[ 65%] Building CXX object llvm/keystone/CMakeFiles/keystone.dir/ks.cpp.o
[ 65%] Building CXX object llvm/keystone/CMakeFiles/keystone.dir/EVMMapping.cpp.o
/home/conan/.conan2/p/b/keyst2d5b9cc91f5ff/b/src/llvm/keystone/ks.cpp: In function 'ks_err ks_option(ks_engine*, ks_opt_type, size_t)':
/home/conan/.conan2/p/b/keyst2d5b9cc91f5ff/b/src/llvm/keystone/ks.cpp:536:38: warning: this statement may fall through [-Wimplicit-fallthrough=]
536 | ks->MAI->setRadix(16);
| ~~~~~~~~~~~~~~~~~^~~~
/home/conan/.conan2/p/b/keyst2d5b9cc91f5ff/b/src/llvm/keystone/ks.cpp:537:17: note: here
537 | case KS_OPT_SYNTAX_NASM:
| ^~~~
/home/conan/.conan2/p/b/keyst2d5b9cc91f5ff/b/src/llvm/keystone/ks.cpp:544:38: warning: this statement may fall through [-Wimplicit-fallthrough=]
544 | ks->MAI->setRadix(16);
| ~~~~~~~~~~~~~~~~~^~~~
/home/conan/.conan2/p/b/keyst2d5b9cc91f5ff/b/src/llvm/keystone/ks.cpp:545:17: note: here
545 | case KS_OPT_SYNTAX_GAS:
| ^~~~
[ 66%] Linking CXX shared library ../lib/libkeystone.so
Plus, consider using the Cmake template recipe for CCI on next time: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package/
It should save your time for new recipes. The templates are updated to be Conan 2.x compatible only, the current state in CCI.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Thank you for your help. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Thank you for your support. |
When building locally I see the follow error:
The It results that this recipe only work with cppstd<17 |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Thank you for your improvements! |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Thank you for clarifying upon licenses. |
The CI runs C++17 by default, so I built locally on Linux and MacOS, to be sure: https://gist.github.com/uilianries/f9ac65208c96934768f2520e1c18ac1a Looking good the build logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your PR!
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Thank you for making it clean upon licenses. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Thanks a lot for taking the time to push this PR to the finish line @luadebug, we appreciate it :) |
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Summary
Changes to recipe: keystone/0.9.2
Motivation
Keystone assembler framework: Core (Arm, Arm64, Hexagon, Mips, PowerPC, Sparc, SystemZ & X86) + bindings
Details
Adds the keystone library version 0.9.2