mariadb-connector-cpp: initial commit (rediscovered) #26026
Conversation
There was a problem hiding this comment.
- do not rename libraries
- retain the declspec
@perseoGI - please remember we do not rename libraries in Conan Center - as the library names may be already relied upon outside of Conan, and we do not want potential consumers to have to use this library differently in Conan. If the upstream project generates mariadbcpp-static.lib - then the only action is to make sure this is reflected in cpp_info.
As for the declspec being removed here: 0d5e959 - I had added it to reflect what upstream defines for consumers https://github.com/mariadb-corporation/mariadb-connector-cpp/blob/d2dc327ee54cdfcb91bf241dbc6cdcccf5447c4c/CMakeLists.txt#L575 . It may be that the header files define it as a fallback, but I think we should closely match the original files.
Note that some of the commits in this PR are from here #24653 - and I had added and authored some fixes. Unsure why that PR was closed and reopened as a new one, but I think it should correctly reflect all authors before merging.
|
We we already looking into it as of last Friday - we are actively going through the backlog, so no need to open/reopen :) |
|
you stopped working at some point, I thought it would be abandoned. 😅 Although it was a weekend 🙂 |
Oh no worries here! not about merits - we just need to make sure we trace the correct author attribution for CLA purposes - as well as avoiding the minor confusion with the two PR on the reviewers side |
Summary
Changes to recipe: mariadb-connector-cpp/1.1.4
Motivation
mariadb-connector-cpp support
Details
on c++
the past pull request: #24653