hictk: add v2.0.1 and bump deps #26078
Conversation
There was a problem hiding this comment.
Hi! As always, thanks a lot for taking the time to ensure the library is kept up-to-date in CCI, we appreciate it
I have one question about the new dependencies in your CMakeLists, and I'll check tomorrow the state of conflicts with the new changes, thanks a lot for the improvements there too :)
| @@ -51,18 +51,18 @@ def config_options(self): | |||
|
|
|||
| def requirements(self): | |||
There was a problem hiding this comment.
In paulsengroup/hictk@v1.0.0...v2.0.1#diff-2def7ae0f4 I see that a few new dependencies were added - are they missing here on pourpose?
There was a problem hiding this comment.
Correct, they are left out on purpose :).
The reason is that the hictk repo hosts code for the C++ library (which is what is currently packaged by Conan) and a CLI application (and tests of course).
The dependencies omitted here are required by either the CLI application or the tests.
I have this command that I use to check I have not forgot to add some deps:
user@dev:/tmp$ find src/libhictk -type f -name "CMakeLists.txt" -exec grep 'find_package' {} + | cut -f 2 -d : | sort -u
find_package(Arrow REQUIRED QUIET)
find_package(bshoshany-thread-pool REQUIRED)
find_package(concurrentqueue REQUIRED)
find_package(Eigen3 QUIET REQUIRED)
find_package(Eigen3 REQUIRED QUIET)
find_package(FastFloat REQUIRED)
find_package(FMT REQUIRED)
find_package(HDF5 REQUIRED QUIET COMPONENTS C)
find_package(HighFive REQUIRED)
find_package(libdeflate REQUIRED)
find_package(phmap REQUIRED)
find_package(readerwriterqueue REQUIRED)
find_package(span-lite REQUIRED)
find_package(spdlog REQUIRED)
find_package(spdlog REQUIRED QUIET)
find_package(zstd REQUIRED)
|
@AbrilRBS friendly ping :) |
Summary
Changes to recipe: hictk/all
Motivation
Add the latest version of hictk and bump a few dependencies to solve current version conflicts and lower the chance of future conflicts.
Note that the recipe does not currently build when
hictk/*:with_arrow=Truebecause highfive requests boost v1.84.0 while arrow requests v1.85.0.I've opened #26079 to solve the version conflict.
Details