-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libiec61850: new recipe #26096
base: master
Are you sure you want to change the base?
libiec61850: new recipe #26096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for taking the time to implement this recipe, we appreciate it. I have some minor comments, and an important point with the vendorized dependencies, but this looks good as a starting point :)
Hi @inPhraZ! I have contributed some changes to your PR. The library had some issues packaging the correct configuration for shared/static (the library builds both by default). There were some issues with the cmake install as well mixing both configurations, so I replaced them with the copy calls. I tested on windows both shared and static and they seem to work. Let's see what the CI says. Thank you! |
Thanks @danimtb |
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,4 @@ | |||
sources: | |||
"1.5.3": | |||
url: "https://github.com/mz-automation/libiec61850/archive/refs/tags/v1.5.3.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the most recent version available, 1.6.0 seems to have been released a few months ago:
https://github.com/mz-automation/libiec61850/releases/tag/v1.6.0 - any reason why we wouldnt start with the most recent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we wouldnt start with the most recent?
Yes, the latest release version (1.6.0) has an issue where one of the required header files is missing from the installation path, causing the test_package to fail. Although this issue has been addressed and fixed in this PR, it has not yet been included in an official release.
Summary
Changes to recipe: libiec61850/1.5.3
Motivation
Adds libiec61850: an open-source library for the IEC 61850 protocols.
https://github.com/mz-automation/libiec61850
Details