Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny-optional: add recipe #26186

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 14, 2024

Summary

Changes to recipe: tiny-optional/1.4.0

Motivation

Try to fix #26180.

Details

https://github.com/Sedeniono/tiny-optional


target_link_libraries(${PROJECT_NAME} PRIVATE tiny-optional::tiny-optional)
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)

if(NOT ${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A CMake comment on why this is necessary would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valgur
Thanks for review!
I add reason for these definitions.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toge and others added 5 commits December 15, 2024 02:12
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] tiny-optional/1.3.1
2 participants