Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnftnl: add new recipe (#26198) #26200

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nikitasinys
Copy link
Contributor

@nikitasinys nikitasinys commented Dec 16, 2024

Summary

Add new recipe: libnftnl/[1.2.8], fixes #26198

Motivation

This library helps to work with nf_tables subsystem


@nikitasinys nikitasinys marked this pull request as draft December 16, 2024 10:44
@nikitasinys nikitasinys marked this pull request as ready for review December 16, 2024 10:58
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. The Windows shared validation needs to be moved to validate().

@nikitasinys nikitasinys marked this pull request as draft December 16, 2024 12:13
@nikitasinys
Copy link
Contributor Author

Thanks! LGTM. The Windows shared validation needs to be moved to validate().

Thanks for review!

@nikitasinys nikitasinys marked this pull request as ready for review December 16, 2024 13:29
@nikitasinys nikitasinys requested a review from valgur December 17, 2024 13:24
@nikitasinys
Copy link
Contributor Author

Hi @conan-io/barbarians,
I have an hanging pre-check for 20 days in two of my PR (this PR and #26204), it's also still hanging after adding new commits
Can you please look at it?

@nikitasinys
Copy link
Contributor Author

Hi @uilianries
I have an issues with hanging pre-checks for more than a month in two of my PR, I tried to ping @conan-io/barbarians but probably mentioning didn't worked. Can you please look at it?

Hi @conan-io/barbarians, I have an hanging pre-check for 20 days in two of my PR (this PR and #26204), it's also still hanging after adding new commits Can you please look at it?

@uilianries
Copy link
Member

@nikitasinys An internal error occurred when running your PR. I just reported internally to take action. Sorry for the occurrence.

@uilianries
Copy link
Member

@nikitasinys An internal hotfix is now running over your PR and fixed your previous error. Still, the requirement libmnl has a small bug in still recipe which is breaking the continuation of the CI too. The PR #26542 should address it. Sorry for the inconvenience again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] libnftnl/1.2.8
3 participants