-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package(sdl): Add version 3.2.0 #26464
base: master
Are you sure you want to change the base?
Conversation
eeba55c
to
21e9fdb
Compare
Whoops I guess there is one already after all, which didn't show up in search... Feel free to close if desired. I don't know what CI is complaining about, builds locally. |
I've tested this MR on 🟢 windows with msvc I would be in favour of this MR since #25873 seems behind |
This is the issue on windows with mingw build:
Tomorrow I will try to fix this issue :) Well done! 🥳 |
The only mention of iconv in SDL seems to be within hidapi (specifically libusb). However I do not have a MinGW setup to test it. |
I did test it but I don't understand the issue; the test package is failing because iconv is not there, but it is there: sdl is having it as requirement in the package_info method. Testing is pretty straightforward since mingw-builds/14.2.0 is a Conan package and can be used as tool requirement. In the end I think it's even not that important since SDL on Windows with MinGW it's not very common. |
I can try to have the same scenario with sdl2. I will let you know tomorrow. |
I tried to build SDL 2.30.9 with the same profile and still get the same error on the test package. So this PR didn't add any new odd behavior. For clarity I am posting the used profile:
|
So you convinced me to run the mingw, and it seems to complete without any issues. The only difference is I don't use an ancient c++ standard.
|
since it was released during the lifetime of the PR
Interestingly I seem to have crashed the Linter 🗡️ |
Oh that's interesting, but we're both using the same version of C++ the build profile is not used for SDL. |
Please don't worry about linter crashing. The issue has just been resolved. It does not have anything to do with your PR 🐸 |
Summary
Changes to recipe: sdl/3.2.0
Motivation
Add latest versions of SDL3 (3.2.0 and 3.2.2) as I need it. Also requested in #25605
Fixes #25605
Details
Add a new recipe folder due to changes required to CMakeLists.txt in test_package.
Pretty much a copy of the existing one minus a few conditions.
Only tested on Windows.