OpenCV 2.4.13.7 #2743
Merged
OpenCV 2.4.13.7 #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
added
the
blocked
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Merged
madebr
reviewed
Sep 5, 2020
uilianries
removed
the
blocked
|
Failure in build 4 (
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Automatically created by bincrafters-conventions 0.26.1
|
Some configurations of 'opencv/2.4.13.7' failed in build 6 (
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
…ndex into opencv/2.4.13
|
Some configurations of 'opencv/2.4.13.7' failed in build 7 (
|
This reverts commit 9cc62e1.
Automatically created by bincrafters-conventions 0.26.1
|
Oh wait. Is the Jasper update causing problems for OpenCV? Edit: The bot won't push the update anymore until this is clarified. You can revert now again if you want |
|
Some configurations of 'opencv/2.4.13.7' failed in build 9 (
|
|
@Croydon Yes in this case, OpenCV 2.4 requires an older version of Jasper, because some methods are incompatible. That's sad because are different minor versions only. I could provide a patch for OpenCV, accepting Jasper and its new version, but sounds wrong. |
This reverts commit 9435cf0.
|
Some configurations of 'opencv/2.4.13.7' failed in build 10 (
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
All green in build 11 (
|
SpaceIm
reviewed
Oct 26, 2020
SpaceIm
reviewed
Oct 26, 2020
SpaceIm
reviewed
Oct 26, 2020
SpaceIm
reviewed
Oct 27, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
All green in build 25 (
|
SpaceIm
reviewed
Oct 27, 2020
SpaceIm
reviewed
Oct 27, 2020
SpaceIm
reviewed
Oct 27, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
SpaceIm
reviewed
Oct 27, 2020
recipes/opencv/2.x/conanfile.py
Outdated
Comment on lines
198
to
199
| if self.settings.os == "Linux": | ||
| self.cpp_info.components[component].system_libs = ["dl", "m", "pthread", "rt"] |
There was a problem hiding this comment.
Are these system libs direct dependencies of all components?
There was a problem hiding this comment.
Yes, can be observed on the original cmake targets generated.
There was a problem hiding this comment.
probably if I look into each module, we can filter better, I guess the upstream preferred it to avoid more complexity in terms of cmake files and dependencies.
There was a problem hiding this comment.
here are the original files generated by opencv: https://gist.github.com/uilianries/e5de90e8df47b0bd6eae25a25e334c5c
There was a problem hiding this comment.
Thanks. So indeed, all components require these system libs.
|
All green in build 26 (
|
madebr
reviewed
Oct 27, 2020
madebr
reviewed
Oct 27, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
All green in build 27 (
|
SpaceIm
reviewed
Oct 27, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
@uilianries please consider bincrafters#16 for #2743 (comment) |
|
All green in build 28 (
|
|
All green in build 29 (
|
SpaceIm
approved these changes
Oct 27, 2020
Comment on lines
+210
to
+214
| self.cpp_info.components[conan_component_alias].includedirs = [] | ||
| self.cpp_info.components[conan_component_alias].libdirs = [] | ||
| self.cpp_info.components[conan_component_alias].resdirs = [] | ||
| self.cpp_info.components[conan_component_alias].bindirs = [] | ||
| self.cpp_info.components[conan_component_alias].frameworkdirs = [] |
There was a problem hiding this comment.
Just to confirm since I never see these... are they required?
There was a problem hiding this comment.
Those attributes are not empty be default. Required? No really, I would say more optimal maybe.
prince-chrismc
approved these changes
Oct 28, 2020
memsharded
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: opencv/2.4.13.7
Depends on Add GTK (System) #2749conan-center hook activated.