Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add 3.16.9, 3.17.5, 3.18.3 + update OpenSSL + exclude unsupported compilers #2941

Merged
merged 7 commits into from
Oct 13, 2020

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Sep 16, 2020

Specify library name and version: cmake/3.16.9, cmake/3.17.5 , cmake/3.18.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (dd24f24e72f32088b72c7e879c8da57b1e203d3b):

  • cmake/3.16.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.3
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.4
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.5
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.6
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.7
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.16.8
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.17.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.17.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.17.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.17.3
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.17.4
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.18.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.18.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • cmake/3.18.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.16.9" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.16.9". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.17.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.17.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)

@Croydon
Copy link
Contributor Author

Croydon commented Sep 16, 2020

Ha. I fall for it too.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Sep 16, 2020
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.9' failed in build 2 (a4bbbdc6bb6a1c083ef4847cb0e9598995ea906f):

@prince-chrismc
Copy link
Contributor

RIP - file too long

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppBuild.targets(321,5): error MSB3491: Could not write lines to file "pseudo_emulator_custom_command.dir\Release\pseudo_e.F4792B4A.tlog\pseudo_emulator_custom_command.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\w\cci_PR-2941@3\2\11e15847-1e31-40d1-a9a9-014aa6f1b526\.conan\data\cmake\3.16.9\_\_\build\6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7\Tests\RunCMake\pseudo_emulator_custom_command.vcxproj]

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppBuild.targets(321,5): error MSB3491: Could not write lines to file "pseudo_emulator_custom_command_arg.dir\Release\pseudo_e.03E80CCC.tlog\pseudo_emulator_custom_command_arg.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\w\cci_PR-2941@3\2\11e15847-1e31-40d1-a9a9-014aa6f1b526\.conan\data\cmake\3.16.9\_\_\build\6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7\Tests\RunCMake\pseudo_emulator_custom_command_arg.vcxproj]

prince-chrismc
prince-chrismc previously approved these changes Sep 17, 2020
@uilianries
Copy link
Member

/cc @danimtb The log is too long. Probably the can't parse its result.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.9' failed in build 3 (a4bbbdc6bb6a1c083ef4847cb0e9598995ea906f):

@danimtb
Copy link
Member

danimtb commented Sep 21, 2020

please check again, I think the error is different

@uilianries
Copy link
Member

CMake Error at CMakeLists.txt:109 (message):
The C++ compiler does not support C++11 (e.g. std::unique_ptr).

Now requires C++11

@Croydon
Copy link
Contributor Author

Croydon commented Sep 21, 2020

This is odd. Why would they raise suddenly the c++ standard in a patch release?

@uilianries
Copy link
Member

I don't know, I'll check tomorrow, sounds weird indeed.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.9' failed in build 4 (44f9c44f354253cddb665b156615129396750814):

@Croydon Croydon changed the title cmake: add 3.16.9 and 3.17.5 cmake: add 3.16.9, 3.17.5 and 3.18.3 Sep 22, 2020
@uilianries
Copy link
Member

I don't think that's a new requirement, but a bug in cmake. unique_ptr is listed since 3 years ago, but there is a small change from 2 weeks ago in the cmake file which checks all requires features, including unique_ptr: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Source/Checks/cm_cxx_features.cmake#L26

@Croydon
Copy link
Contributor Author

Croydon commented Sep 27, 2020

Indeed. CMake requires at least C++11, which brings me to the question: Which of the many ways to exclude compilers based on their language support is currently the approach we consider the best? Currently, our recipes use a wild mix of different ways. Also wouldn't this be something worth integrating in Conan itself?

@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Sep 30, 2020
@Croydon Croydon changed the title cmake: add 3.16.9, 3.17.5 and 3.18.3 cmake: add 3.16.9, 3.17.5 and 3.18.3 + update OpenSSL + exclude unsupported compilers Sep 30, 2020
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.2' failed in build 6 (85b8dd310aae409d4e39681f017034be64e9b563):

@Croydon
Copy link
Contributor Author

Croydon commented Sep 30, 2020

-- Checking if compiler supports C++ make_unique
-- Checking if compiler supports C++ make_unique - no
-- Checking if compiler supports C++ unique_ptr
-- Checking if compiler supports C++ unique_ptr - no
CMake Error at CMakeLists.txt:109 (message):
  The C++ compiler does not support C++11 (e.g.  std::unique_ptr).

I really don't understand what's going on here.

CMake is supporting VS2015+
And VS2015+ is supporting std::unique_ptr

I can also build locally without problems with VS2019

Edit: And now Kitware's Gitlab is down. So I can't look things up.. 🙄

@uilianries
Copy link
Member

uilianries commented Sep 30, 2020

@Croydon Maybe it's a specific version of MSVC 14

@Croydon
Copy link
Contributor Author

Croydon commented Sep 30, 2020

It also failed with MSVC 15 and 16 on CI: #2941 (comment)

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.2' failed in build 7 (caaa1ed67b879f2d240ad2c2d939eb9ed66211cc):

@Croydon Croydon changed the title cmake: add 3.16.9, 3.17.5 and 3.18.3 + update OpenSSL + exclude unsupported compilers cmake: add 3.16.9, 3.17.5, 3.18.3, 3.18.4 + update OpenSSL + exclude unsupported compilers Oct 7, 2020
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@jgsogo
Copy link
Contributor

jgsogo commented Oct 8, 2020

Now I have to rebase, push and wait for another 12 hours or so.🙄

Yes. This is something we need to discuss. It is a problem which can only grow (unless we add more and more machines). Alternatives would be to remove versions or compile fewer profiles (or compile fewer profiles for older versions)... not sure if there are any other options 🤔 We need to talk about it.

@Croydon
Copy link
Contributor Author

Croydon commented Oct 8, 2020

-> #2813 ?

In this case I was (temporary) annoyed that pretty much a duplicate PR got merged causing this, but I guess it happens

By the way, do we still need to add all those settings for installer packages like CMake?

settings = "os", "arch", "compiler", "build_type"

I kinda lost track of the related problems, but believe to recall that things got better there?

@Croydon
Copy link
Contributor Author

Croydon commented Oct 8, 2020

I think the main concern was Windows and if dynamic runtimes are actually around on the host systems

#1783 (comment)

@jgsogo IIRC we have now a guaranteed order for the compiler versions. Do we also have a guaranteed order for the runtimes and is Windows building with static runtimes first?

Edit: According to the changelog, we have a guaranteed order of the profiles

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@Croydon Croydon closed this Oct 8, 2020
@Croydon Croydon reopened this Oct 8, 2020
@jgsogo
Copy link
Contributor

jgsogo commented Oct 9, 2020

@solvingj is trying to gather together the pros and cons of building all/some profiles of all/some versions. As with many other things, the implementation is not going to be the blocker, but we need to know the consequences.

About the order of profiles, it is in my TODO list. I need to double check it is working as expected. But there are so many conflicting priorities that I never find the time to run that check and open the PR and document the intention. Let's check it right now (#3153).

@Croydon
Copy link
Contributor Author

Croydon commented Oct 9, 2020

@jgsogo Thank you so much for your work. I hope I didn't cause more stress ❤️

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.9' failed in build 14 (79cba5051bba3e940c40f5a4de911bb0de1329a5):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.2' failed in build 15 (e8e14e723daf0a2254a17d3b510017ba35312936):

@conan-center-bot
Copy link
Collaborator

All green in build 16 (0460d0a330361fbc8ae1cc455d9964fe895720bc)! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants