-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: add 3.16.9, 3.17.5, 3.18.3 + update OpenSSL + exclude unsupported compilers #2941
Conversation
Failure in build 1 (
|
Ha. I fall for it too. |
Some configurations of 'cmake/3.16.9' failed in build 2 (
|
RIP - file too long
|
/cc @danimtb The log is too long. Probably the can't parse its result. |
Some configurations of 'cmake/3.16.9' failed in build 3 (
|
please check again, I think the error is different |
Now requires C++11 |
This is odd. Why would they raise suddenly the c++ standard in a patch release? |
I don't know, I'll check tomorrow, sounds weird indeed. |
Some configurations of 'cmake/3.16.9' failed in build 4 (
|
I don't think that's a new requirement, but a bug in cmake. unique_ptr is listed since 3 years ago, but there is a small change from 2 weeks ago in the cmake file which checks all requires features, including unique_ptr: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Source/Checks/cm_cxx_features.cmake#L26 |
Indeed. CMake requires at least C++11, which brings me to the question: Which of the many ways to exclude compilers based on their language support is currently the approach we consider the best? Currently, our recipes use a wild mix of different ways. Also wouldn't this be something worth integrating in Conan itself? |
Some configurations of 'cmake/3.16.2' failed in build 6 (
|
I really don't understand what's going on here. CMake is supporting VS2015+ I can also build locally without problems with VS2019 Edit: And now Kitware's Gitlab is down. So I can't look things up.. 🙄 |
@Croydon Maybe it's a specific version of MSVC 14 |
It also failed with MSVC 15 and 16 on CI: #2941 (comment) |
Some configurations of 'cmake/3.16.2' failed in build 7 (
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Yes. This is something we need to discuss. It is a problem which can only grow (unless we add more and more machines). Alternatives would be to remove versions or compile fewer profiles (or compile fewer profiles for older versions)... not sure if there are any other options 🤔 We need to talk about it. |
-> #2813 ? In this case I was (temporary) annoyed that pretty much a duplicate PR got merged causing this, but I guess it happens By the way, do we still need to add all those settings for installer packages like CMake?
I kinda lost track of the related problems, but believe to recall that things got better there? |
I think the main concern was Windows and if dynamic runtimes are actually around on the host systems @jgsogo IIRC we have now a guaranteed order for the compiler versions. Do we also have a guaranteed order for the runtimes and is Windows building with static runtimes first? Edit: According to the changelog, we have a guaranteed order of the profiles |
An unexpected error happened and has been reported. Help is on its way! 🏇 |
@solvingj is trying to gather together the pros and cons of building all/some profiles of all/some versions. As with many other things, the implementation is not going to be the blocker, but we need to know the consequences. About the order of profiles, it is in my TODO list. I need to double check it is working as expected. But there are so many conflicting priorities that I never find the time to run that check and open the PR and document the intention. Let's check it right now (#3153). |
@jgsogo Thank you so much for your work. I hope I didn't cause more stress ❤️ |
Some configurations of 'cmake/3.16.9' failed in build 14 (
|
Some configurations of 'cmake/3.16.2' failed in build 15 (
|
All green in build 16 (
|
Specify library name and version: cmake/3.16.9, cmake/3.17.5 , cmake/3.18.3
conan-center hook activated.