-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignition-math #3215
Add ignition-math #3215
Conversation
Some configurations of 'ignition-math/6.6.0' failed in build 1 (
|
def source(self): | ||
tools.get(**self.conan_data["sources"][self.version]) | ||
version_major = self.version.split('.')[0] | ||
os.rename(f"ign-math-ignition-math{version_major}_{self.version}", self._source_subfolder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this format is not support in the minimum python version CCI supports, we have to use "".format()
You can also use the https://docs.conan.io/en/latest/reference/tools.html#tools-version to get the major version
@@ -0,0 +1,13 @@ | |||
cmake_minimum_required(VERSION 3.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe CXX_STANDARD 17 was introduced in 3.8
Some configurations of 'ignition-math/6.6.0' failed in build 2 (
|
Since the test_package requires c++17 support, I assume the main project does as well, in that case you will need to set the "minimum compiler support" this is an example that easy to copy-paste conan-center-index/recipes/tomlplusplus/all/conanfile.py Lines 27 to 51 in 2b092c3
|
Failure in build 3 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 4 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 5 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 6 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 7 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 8 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 9 (
|
Some configurations of 'ignition-math/6.6.0' failed in build 10 (
|
The error that I'm getting:
seems to be a bug in So basically the problem is when using What would be the best way to avoid a specific configuration, in this case, static libraries with |
Some configurations of 'ignition-math/6.6.0' failed in build 17 (
|
I haven't looked into the clang problem yet, but please consider joxoby#1 |
That can be done in configure: def configure(self):
if not self.options.shared and self.settings.compiler == "clang" and self.settings.compiler.libcxx = "libc++":
raise ConanInvalidConfiguration("Due to a clang bug, this package cannot be used as a static library with libcxx==libc++.") Eventually, you can filter finer by using |
Some configurations of 'ignition-math/6.6.0' failed in build 18 (
|
I forgot to add the wrapper cmake script... oops See joxoby#2 |
I cannot reproduce the
|
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
All green in build 20 (
|
Right now, it downloads both ignition-math and ignition-cmake. |
Ok wow! This is super interesting. What ended up fixing the problems was the CMake wrapper script. The wrapper added some linker flags to the compilation of the source code that were not passed in previously. For example, during the build of
Thanks @madebr ! |
Yes, there will be more ignition packages coming, but I failed at making an |
Currently, |
Please create one, the conan hooks will probably fail because it does not allow cmake scripts in the package. |
Ok, working on it now. |
Draft PR for |
See joxoby#2, |
Some configurations of 'ignition-math/6.6.0' failed in build 21 (
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: ignition-math/6.6.0
conan-center hook activated.