libsndfile: ogg/flac/opus/vorbus are recommended dependencies (not required) + remove sqlite dependency #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
commented
Nov 20, 2020
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
|
All green in build 2 (
|
SSE4
reviewed
Nov 21, 2020
madebr
commented
Nov 21, 2020
|
All green in build 3 (
|
| @@ -16,15 +17,18 @@ class LibsndfileConan(ConanFile): | |||
| "programs": [True, False], | |||
| "experimental": [True, False], | |||
| "with_alsa": [True, False], | |||
| "with_sqlite": [True, False], | |||
| "with_sqlite": ["deprecated", True, False], | |||
| "with_external_libs": [True, False], | |||
There was a problem hiding this comment.
Could these be controlled individually?
There was a problem hiding this comment.
No, ENABLE_EXTERNAL_LIBS needs all.
https://github.com/libsndfile/libsndfile/blob/91128fcd60ab13cca0b1475960c75b07cdca7b04/CMakeLists.txt#L79
prince-chrismc
previously approved these changes
Nov 22, 2020
|
All green in build 4 (
|
|
@uilianries @SpaceIm @SSE4 |
SSE4
previously approved these changes
Dec 1, 2020
SpaceIm
reviewed
Dec 2, 2020
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
SpaceIm
approved these changes
Dec 2, 2020
prince-chrismc
approved these changes
Dec 2, 2020
|
All green in build 5 (
|
SSE4
approved these changes
Dec 3, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libsndfile/*
sqlite3 is only used by regtest, which is not built
ogg/flac/opus/vorbus are recommended dependencies, not absolutely required (so make them optional)
I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.