Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: bump expat #3662

Merged
merged 3 commits into from
Nov 26, 2020
Merged

wayland: bump expat #3662

merged 3 commits into from
Nov 26, 2020

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: wayland/*

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (1d4c94f4d873c6515e7305602b4e026d4c2017b9)! 😊

@ericLemanissier ericLemanissier marked this pull request as draft November 23, 2020 06:54
@ericLemanissier
Copy link
Contributor Author

I'll add components later today

@SSE4 SSE4 requested a review from uilianries November 23, 2020 07:31
SSE4
SSE4 previously approved these changes Nov 23, 2020
View reviewed changes
@ericLemanissier ericLemanissier marked this pull request as ready for review November 23, 2020 08:07
@conan-center-bot
Copy link
Collaborator

All green in build 2 (1872ee3957c7ff79c961adc10db70858c51fb1b0)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 3 (1f997c3106e20c62e6ac0cc1e794e5c2c53934fc)! 😊

@ericLemanissier ericLemanissier mentioned this pull request Nov 23, 2020
Closed
4 tasks
@ericLemanissier ericLemanissier requested a review from SSE4 November 23, 2020 08:56
@ericLemanissier
Copy link
Contributor Author

this blocks #3663

@prince-chrismc
Copy link
Contributor

tag the reviewers #2857

uilianries
uilianries reviewed Nov 24, 2020
View reviewed changes
recipes/wayland/all/conanfile.py

if self.options.enable_libraries:
self.cpp_info.components["wayland-server"].libs = ["wayland-server"]
self.cpp_info.components["wayland-server"].names["pkg_config"] = "wayland-server"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about CMake targets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't exist AFAIK https://packages.ubuntu.com/groovy/amd64/libwayland-dev/filelist

@conan-center-bot conan-center-bot merged commit 2b4c889 into conan-io:master Nov 26, 2020
@ericLemanissier ericLemanissier deleted the patch-1 branch November 26, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericLemanissier @conan-center-bot @prince-chrismc @SSE4 @uilianries