-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add boost/1.75.0 #3872
boost: add boost/1.75.0 #3872
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Some configurations of 'boost/1.69.0' failed in build 1 (
|
Some configurations of 'boost/1.69.0' failed in build 2 (
|
…ers or with too old default
Failure in build 6 (
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Failure in build 7 (
|
Some configurations of 'boost/1.75.0' failed in build 8 (
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Failure in build 22 (
|
Failure in build 23 (
|
Some configurations of 'boost/1.73.0' failed in build 24 (
|
Thanks for the reply! May I suggest to add a file/message in the logs/directory saying that a build is cancelled (+ the reason why)? |
All green in build 25 (
|
All green in build 26 (
|
I am not a reviewer but this PR looks good to me. |
@fpelliccioni It is true that there are some official reviewers, but we'd love to have more. Even if your approval (right now) is not taken into account for the number of 3 required, for us, it is useful to know which people are contributing to reviews in case we want to add someone else. Feel free to approve/reject PRs, it is always useful. |
I also approved for the same reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only a new release, but also a great improvement
We're still using apple-clang 10, and the guess of 12 for various support is a bit high; 10 still works. Can we put in this patch? diff --git a/recipes/boost/all/conanfile.py b/recipes/boost/all/conanfile.py
index 1782b831..bac11c02 100644
--- a/recipes/boost/all/conanfile.py
+++ b/recipes/boost/all/conanfile.py
@@ -137,7 +137,7 @@ class BoostConan(ConanFile):
return {
"gcc": 6,
"clang": 6,
- "apple-clang": 12, # guess
+ "apple-clang": 10, # guess
"Visual Studio": 14, # guess
}.get(str(self.settings.compiler))
@@ -147,7 +147,7 @@ class BoostConan(ConanFile):
return {
"gcc": 5,
"clang": 5,
- "apple-clang": 12, # guess
+ "apple-clang": 10, # guess
"Visual Studio": 14, # guess
}.get(str(self.settings.compiler)) This was my build configuration:
Boost reported:
...and ETA: Works means if I create a Conan package, the test_package builds and runs. |
@datalogics-kam I guess automatic merging was faster than you. |
@mathbunnyru No worries, I just thought up something more to test on our config today. I'll get that PR up shortly. |
@datalogics-kam The main problem that was haunting me is that b2 tests compiler features using the configured c++ version. |
I think the real answer is for end users to set I think it's reasonable for the recipe to check |
@datalogics-kam maybe this can give you some insights: conan-io/examples#73 It is a quick draft, but it shows how recipes could look like in the future. |
Specify library name and version: boost/1.75.0
Fixes #3899: assertions are still here, but the options have correct(er) defaults
Fixes #3895: allow building with a static icu dependency (
-o boost:i18n_backend=icu
)Fixes #3890: fix building with Android
Fixes #3869: libsuffix of a versioned layout is calculated correctly (:crossed_fingers:) now
Fixes #3867: define
BOOST_(AS|SP)_USE_PTHREADS
Fixes #3863: this adds 1.75.0
Fixes #3522: this line has been changed by the layout change
Fixes #3205: test_package uses targets now
Fixes #1925: boost uses components now
math
andrandom
.conan-center hook activated.