qpoases/3.2.1 #3962

blackliner · 2020-12-20T20:14:50Z

Specify library name and version: qpoases/3.2.1

I got 3 open points/questions to the community:

The library has only one STATIC target, so I want to disable shared. Is the way I did this correct? Bonus: Do I need fPIC at all?

    options = {
        "fPIC": [True, False],
        "shared": [False],
    }

The current library exports a target called qpOASES (no leading qpOASES::). This target is not available with the conan package anymore, so existing consumers have to rewrite their CML, right?
I had to add a component named qpOASES::qpOASES to make it all work, any ideas why? SOLVED: self.cpp_info.libs = tools.collect_libs(self) was missing

The important stuff:

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-12-20T20:15:14Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-12-20T20:18:39Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

prince-chrismc

You certainly should not need components, just the names is enough.

We have to have a namespace for cmake but feel free to add a FIXME comment so we do not forget!

Also you sent cmake version to 3.10 by convenience we sent to 3.1 but that's not an issue.

On mobile but LGTM! Amazing work

recipes/qpoases/all/conanfile.py

blackliner · 2020-12-21T09:47:04Z

You certainly should not need components, just the names is enough.

I learned some more during yesterdays port of ACADE, self.cpp_info.libs = tools.collect_libs(self) was missing 👍

We have to have a namespace for cmake but feel free to add a FIXME comment so we do not forget!

If you can tell me what this means or point me to an example, I can try and add it.

Also you sent cmake version to 3.10 by convenience we sent to 3.1 but that's not an issue.

done

On mobile but LGTM! Amazing work

Thanks 😄

conan-center-bot · 2020-12-21T09:48:20Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

madebr · 2020-12-21T15:50:07Z

I think the Makefile is an afterthought.
INSTALL.txt tells to use the makefiles.

The project has some Makefiles: make_linux.mk, make_osx.mk and make_windows.mk.
Do these work?

The makefiles contain references to BLAS, LAPACK and libhsl.
Are these potential dependencies?

uilianries

Thanks for your contribution, only a few points to be checked.

recipes/qpoases/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-12-21T22:19:46Z

Failure in build 4 (67d243628fe2da64fbfb4435500c777d65a4f35f):

Error processing recipe (ref 'qpoases/3.2.1'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: qpoases:shared-True
Unexpected error happened:

ERROR: qpoases/3.2.1: 'True' is not a valid 'options.shared' value.
Possible values are ['False']

blackliner · 2020-12-21T22:26:24Z

I think the Makefile is an afterthought.
INSTALL.txt tells to use the makefiles.

The project has some Makefiles: make_linux.mk, make_osx.mk and make_windows.mk.
Do these work?

The makefiles contain references to BLAS, LAPACK and libhsl.
Are these potential dependencies?

I do not know if the INSTALL.txt is really up to date. The lib is not under active development anymore, but needed for another one: https://github.com/acado/acado Both are from the same dev.

I only ever used the CML, and it works without any obvious dependencies (no find_package nor target_link_libraries) .

conan-center-bot · 2020-12-21T22:29:32Z

Failure in build 5 (dbee32ca7aa0686f499df7d4ea41fa209501133f):

Error processing recipe (ref 'qpoases/3.2.1'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: qpoases:shared-True
Unexpected error happened:

ERROR: qpoases/3.2.1: 'True' is not a valid 'options.shared' value.
Possible values are ['False']

conan-center-bot · 2020-12-22T19:44:54Z

Some configurations of 'qpoases/3.2.1' failed in build 6 (b0c2480760e9ac98bdc102bd7d39754b6b191800):

Windows x86_64, Release, Visual Studio 15, MT
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MT
Access to all the logs

recipes/qpoases/all/test_package/CMakeLists.txt

recipes/qpoases/all/test_package/conanfile.py

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

conan-center-bot · 2020-12-23T13:43:10Z

Some configurations of 'qpoases/3.2.1' failed in build 7 (3e8086f4444734f77bc24ae34c7a252bb459319f):

Macos x86_64, Debug, apple-clang 11.0, libc++
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT
Access to all the logs

recipes/qpoases/all/test_package/CMakeLists.txt

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

conan-center-bot · 2020-12-23T20:40:09Z

Some configurations of 'qpoases/3.2.1' failed in build 8 (286ca5a5b462543a9c495856a10f2f239d80faf3):

Macos x86_64, Debug, apple-clang 11.0, libc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 3.9, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 3.9, libc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 4.0, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 5.0, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 7, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 7, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 5, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 9, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 5, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 6, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 4.0, libc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 6.0, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 8, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 7, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 9, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 6, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 7, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 9, libstdc++11
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 9, libc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 8, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 9, libstdc++
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MT
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-12-23T21:15:16Z

All green in build 9 (7f49423c4feb91356b975e45ba18303f60aea7d5)! 😊

qpoases/3.2.1: Generated 68 packages. All logs here

uilianries

LGTM

conan-center-bot added the No Beta user label Dec 20, 2020

qpoases/3.2.1

a483486

blackliner force-pushed the qpoases branch from 28b0543 to a483486 Compare December 20, 2020 20:18

prince-chrismc previously approved these changes Dec 21, 2020

View reviewed changes

recipes/qpoases/all/conanfile.py Outdated Show resolved Hide resolved

comments

147acd9

blackliner dismissed prince-chrismc’s stale review via 147acd9 December 21, 2020 09:47

uilianries requested changes Dec 21, 2020

View reviewed changes

recipes/qpoases/all/conanfile.py Outdated Show resolved Hide resolved

recipes/qpoases/all/conanfile.py Outdated Show resolved Hide resolved

recipes/qpoases/all/conanfile.py Outdated Show resolved Hide resolved

recipes/qpoases/all/conanfile.py Show resolved Hide resolved

Update recipes/qpoases/all/conanfile.py

67d2436

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot removed the No Beta user label Dec 21, 2020

conan-center-bot added the Failed label Dec 21, 2020

no more glob

dbee32c

blackliner mentioned this pull request Dec 22, 2020

acado/1.2.2 #3967

Merged

4 tasks

remove shared as option

b0c2480

madebr reviewed Dec 22, 2020

View reviewed changes

recipes/qpoases/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

madebr reviewed Dec 22, 2020

View reviewed changes

recipes/qpoases/all/test_package/conanfile.py Outdated Show resolved Hide resolved

Apply suggestions from code review

3e8086f

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

madebr reviewed Dec 23, 2020

View reviewed changes

recipes/qpoases/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

Update recipes/qpoases/all/test_package/CMakeLists.txt

286ca5a

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

c++ std 11 and fixed name of bin

7f49423

conan-center-bot removed the Failed label Dec 23, 2020

blackliner requested a review from uilianries December 23, 2020 21:15

madebr approved these changes Dec 23, 2020

View reviewed changes

prince-chrismc approved these changes Dec 23, 2020

View reviewed changes

SSE4 approved these changes Dec 24, 2020

View reviewed changes

github-actions bot mentioned this pull request Dec 26, 2020

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries approved these changes Jan 5, 2021

View reviewed changes

conan-center-bot merged commit 8cbc1ce into conan-io:master Jan 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qpoases/3.2.1 #3962

qpoases/3.2.1 #3962

blackliner commented Dec 20, 2020 •

edited

Loading

conan-center-bot commented Dec 20, 2020

conan-center-bot commented Dec 20, 2020

prince-chrismc left a comment

blackliner commented Dec 21, 2020

conan-center-bot commented Dec 21, 2020

madebr commented Dec 21, 2020

uilianries left a comment

conan-center-bot commented Dec 21, 2020

blackliner commented Dec 21, 2020

conan-center-bot commented Dec 21, 2020

conan-center-bot commented Dec 22, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

uilianries left a comment

qpoases/3.2.1 #3962

qpoases/3.2.1 #3962

Conversation

blackliner commented Dec 20, 2020 • edited Loading

The important stuff:

conan-center-bot commented Dec 20, 2020

conan-center-bot commented Dec 20, 2020

prince-chrismc left a comment

Choose a reason for hiding this comment

blackliner commented Dec 21, 2020

conan-center-bot commented Dec 21, 2020

madebr commented Dec 21, 2020

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 21, 2020

blackliner commented Dec 21, 2020

conan-center-bot commented Dec 21, 2020

conan-center-bot commented Dec 22, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

conan-center-bot commented Dec 23, 2020

uilianries left a comment

Choose a reason for hiding this comment

blackliner commented Dec 20, 2020 •

edited

Loading