Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cnpy-1.0] upload lib #4032

Merged
merged 26 commits into from
Jan 5, 2021
Merged

[cnpy-1.0] upload lib #4032

merged 26 commits into from
Jan 5, 2021

Conversation

hongyx11
Copy link
Contributor

Specify library name and version: cnpy/1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/1.0' failed in build 1 (222547b77c658cafcec46cc751af0bcd111363b4):

@Croydon Croydon mentioned this pull request Dec 30, 2020
4 tasks
recipes/cnpy/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/cnpy/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cnpy/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cnpy/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cnpy/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cnpy/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
hongyx11 and others added 2 commits December 30, 2020 15:16
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Copy link
Contributor Author

@hongyx11 hongyx11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept change of cxx standard and update zlib requirements, but since this lib needs zlib, I still need to update dependency in the source code. I tried to use conanfile.py for installation, but I met a problem: how to init conan env using conanfile.py?

hongyx11 and others added 5 commits December 30, 2020 15:20
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@uilianries
Copy link
Member

@hongyx11 Could you explain why you are packaging your fork and not the original package?

The original project should be the official package. However, if it's abandoned a fork can be adopted, but it should be accept as "official" fork by the community.

@hongyx11
Copy link
Contributor Author

@uilianries thanks for your message, the reason is I don't how to retrive the source from a github repo. all the examples I saw in conan center are using tar file/ zip file to retrive source. The original repo doesn't have a tar file (tag/release). Please tell me how to do it if you know, thanks! I can change the fork repo to original repo.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/1.0' failed in build 8 (61c962f781e4588897d43bc56c9d8b2e6c344f4d):

uilianries and others added 4 commits December 30, 2020 18:10
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Automatically created by bincrafters-conventions 0.30.1
@uilianries
Copy link
Member

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/cci.20180601' failed in build 9 (af8ed6658e84903ce0f255a4ed5fe9127338d87f):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/cci.20180601' failed in build 10 (10b925d171e2061c6c6b81fae52de1b2deafe3d4):

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/cci.20180601' failed in build 11 (bc4066f72730fc258dfab633e1e09319c2c3e25d):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cnpy/cci.20180601' failed in build 17 (33a0c0e84f1c4d454f1243a7219d13b04d9af2fb):

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green in build 19 (7159ae8a915f5f253fee25a9e09dd87dd101226b)! 😊

prince-chrismc
prince-chrismc previously approved these changes Jan 1, 2021
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

All green in build 20 (d5d8896abebb702bcf6ed31794d75523269906a7)! 😊

@hongyx11 hongyx11 closed this Jan 2, 2021
@madebr
Copy link
Contributor

madebr commented Jan 2, 2021

@hongyx11
I think you accidentally closed this pr.
It got the required approvals and was about to be merged.

@hongyx11 hongyx11 reopened this Jan 2, 2021
@hongyx11
Copy link
Contributor Author

hongyx11 commented Jan 2, 2021

@hongyx11
I think you accidentally closed this pr.
It got the required approvals and was about to be merged.

sorry for the misleading close, I reopen it, thanks!

@conan-center-bot
Copy link
Collaborator

All green in build 21 (d5d8896abebb702bcf6ed31794d75523269906a7)! 😊

@prince-chrismc
Copy link
Contributor

@uilianries is blocking the PR, when he's back to work on Monday I'm sure he'll update his review

From prince-chrismc/conan-center-index-pending-review#1

PR By Recipe Reviews  Blockers  Approvers 
#4032 hongyx11 cnpy 11 uilianries madebr, prince-chrismc, SSE4

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 93a325c into conan-io:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants