add notcurses/2.4.8 recipe

[dankamongmen]

Specify library name and version: notcurses/2.1.2

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

This is my first recipe. I'm the upstream author. Please see dankamongmen/notcurses#1098 for background. Closes #4035.

[CLAassistant]

All committers have signed the CLA.

[dankamongmen]

Hrmm, clicking on "details" to fix up my build draws a 403 :/.

[SpaceIm]

@dankamongmen
Please read https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md. Currently your recipe layout doesn't fit CCI one.

Basically:

• remove all .gitlab-ci.yml and build.py files.
• you have two conanfile.py (one under notcurses and one under notcurses/all), keep only the one under notcurses/all
• there should be a conandata.yml file under notcurses/all, containing url to 2.1.2 archive and sha256 of this archive.
• a CMakeLists.txt wrapper should be added under notcurses/all
• in your conanfile.py:
  • don't use git, but download archive source code (look at other recipes in CCI).
  • pkgconf is very likely a build requirement of your library: https://github.com/dankamongmen/notcurses/blob/449455cf4b2038fb5385946e8e6d2006d9480fb5/CMakeLists.txt#L70
  • remove with_doctest option
  • remove version and author attributes

[dankamongmen]

@dankamongmen
Please read https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md. Currently your recipe layout doesn't fit CCI one.

thanks for the detailed feedback; i'll get on top of this and push anew

[dankamongmen]

I still (at least) need to generate that CMake wrapper and work out pkg-config integration.

[SpaceIm]

test_package folder must be under all folder.
CCI doesn't allow requirements key in conandata.yml (maybe later?). You have to put requirements in conanfile.py

Here is a recipe relying on pkgconf (under condition in this case):

conan-center-index/recipes/mongo-c-driver/all/conanfile.py

Line 86 in 3a29c48

def build_requirements(self):

[dankamongmen]

What about `notcurses++`?

Hrmmm. In Debian, libnotcurses.so and libnotcurses++.so are delivered in two different packages. Most other distros only use a single package. Everywhere, however, two .pc pkg-config files are built. Many programs don't need libnotcurses++, and those that do generally oughtn't need an explicit -lnotcurses. Ought I make a second recipe for libnotcurses++?

[Croydon]

Sounds to me like one recipe with two components (at least) should work well. Components will generate individual targets (e.g. CMake targets) people can link against.

[dankamongmen]

Sounds to me like one recipe with two components (at least) should work well. Components will generate individual targets (e.g. CMake targets) people can link against.

sounds perfect, thanks. i appreciate y'alls' patient assistance! i'm reading the conan-index guide, which seems wildly different from the original documentation i read, but i ought have something smashed together soon.

[dankamongmen]

I've updated to 2.1.4 and smacked it into shape enough to build with conan create. I'm now resolving the several warnings, most of them having to do with undesirable install artifacs:

[HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: [''] (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H019)
[HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/Notcurses++/Notcurses++Config.cmake; ./lib/cmake/Notcurses++/Notcurses++ConfigVersion.cmake; ./lib/cmake/Notcurses/NotcursesConfig.cmake; ./lib/cmake/Notcurses/NotcursesConfigVersion.cmake (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H019)
[HOOK - conan-center.py] post_package(): ERROR: [PC-FILES (KB-H020)] The conan-center repository doesn't allow the packages to contain `pc` files. The packages have to be located using generators and the declared `cpp_info` information (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H020) 
[HOOK - conan-center.py] post_package(): ERROR: [PC-FILES (KB-H020)] Found files: ./lib/pkgconfig/notcurses++.pc; ./lib/pkgconfig/notcurses.pc (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H020) 
[HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared `cpp_info` information (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016) 
[HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files: ./lib/cmake/Notcurses++/Notcurses++Config.cmake; ./lib/cmake/Notcurses/NotcursesConfig.cmake (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016) 
[HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /home/dank/.conan/data/notcurses/2.1.4/_/_/package/1cc46e4935883de8d1741138c7c12bfb79491fc2  (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H012) 
[HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'share' in the package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H013) 

[dankamongmen]

Down to a single warning:

[HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /home/dank/.conan/data/notcurses/2.1.4/_/_/package/1cc46e4935883de8d1741138c7c12bfb79491fc2  (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H012) 

[SSE4]

CMake Error at CMakeLists.txt:160 (message):
  Couldn't find unigbrk.h from GNU libunistring

I've double-checked, package libunistring/0.9.10 contains unigbrk.h header. why couldn't it be found? 🤔

[conan-center-bot]

Failure in build 2 (01fd16f20492a410dbb2b9ac2678026e0d9f4851):

• notcurses/2.4.8@:
  CI failed to create some packages (All logs)

  Logs for packageID d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59:

  [settings]
  arch=x86_64
  build_type=Release
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=5
  os=Linux
  [options]
  notcurses:shared=False
  

  [...]
  See also "/home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/build/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59/CMakeFiles/CMakeOutput.log".
  See also "/home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/build/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59/CMakeFiles/CMakeError.log".
  notcurses/2.4.8: 
  dpkg-query: no packages found matching libgtk2.0-dev
  debconf: delaying package configuration, since apt-utils is not installed
  dpkg-query: no packages found matching libva-dev
  debconf: delaying package configuration, since apt-utils is not installed
  dpkg-query: no packages found matching libvdpau-dev
  debconf: delaying package configuration, since apt-utils is not installed
  dpkg-query: no packages found matching libx11-xcb-dev
  dpkg-query: no packages found matching libfontenc-dev
  dpkg-query: no packages found matching libxaw7-dev
  dpkg-query: no packages found matching libxkbfile-dev
  dpkg-query: no packages found matching libxmu-dev
  dpkg-query: no packages found matching libxmuu-dev
  dpkg-query: no packages found matching libxpm-dev
  dpkg-query: no packages found matching libxres-dev
  dpkg-query: no packages found matching libxss-dev
  dpkg-query: no packages found matching libxt-dev
  dpkg-query: no packages found matching libxv-dev
  dpkg-query: no packages found matching libxvmc-dev
  dpkg-query: no packages found matching libxxf86vm-dev
  dpkg-query: no packages found matching libxcb-render-util0-dev
  dpkg-query: no packages found matching libxcb-xkb-dev
  dpkg-query: no packages found matching libxcb-icccm4-dev
  dpkg-query: no packages found matching libxcb-image0-dev
  dpkg-query: no packages found matching libxcb-keysyms1-dev
  dpkg-query: no packages found matching libxcb-randr0-dev
  dpkg-query: no packages found matching libxcb-shape0-dev
  dpkg-query: no packages found matching libxcb-sync-dev
  dpkg-query: no packages found matching libxcb-xfixes0-dev
  dpkg-query: no packages found matching libxcb-xinerama0-dev
  dpkg-query: no packages found matching xkb-data
  dpkg-query: no packages found matching libxcb-dri3-dev
  dpkg-query: no packages found matching uuid-dev
  dpkg-query: no packages found matching libxcb-util-dev
  debconf: delaying package configuration, since apt-utils is not installed
  CMake Error at CMakeLists.txt:160 (message):
    Couldn't find unigbrk.h from GNU libunistring
  
  
  WARN: flac/1.3.3: requirement ogg/1.3.5 overridden by libsndfile/1.0.31 to ogg/1.3.4 
  tbb/2020.3: WARN: Recipe 'tbb/2020.3' is deprecated in favor of 'onetbb'. Please, consider changing your requirements.
  notcurses/2.4.8: ERROR: Package 'd43febb2e0c3e7eed0be704d1cb0458f1ec7ef59' build failed
  notcurses/2.4.8: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/build/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59
  ERROR: notcurses/2.4.8: Error in build() method, line 31
  	cmake = self._configure_cmake()
  while calling '_configure_cmake', line 51
  	self._cmake.configure(source_folder="notcurses-" + self.version)
  	ConanException: Error 1 while executing cd '/home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/build/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="5" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/package/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_TESTING="OFF" -DUSE_MULTIMEDIA="oiio" -DUSE_PANDOC="OFF" -DUSE_POC="OFF" -DUSE_QRCODEGEN="OFF" -DUSE_STATIC="True" -Wno-dev '/home/conan/w/prod/BuildSingleReference/.conan/data/notcurses/2.4.8/_/_/build/d43febb2e0c3e7eed0be704d1cb0458f1ec7ef59/notcurses-2.4.8'
  

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.