add paho-mqtt-c/1.3.8 #4063

Croydon · 2021-01-03T02:58:21Z

Specify library name and version: paho-mqtt-c/1.3.8

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Croydon · 2021-01-03T03:03:32Z

I have not applied the CMake patch for this, since it is kinda unclear what it is for and it seems to work just fine without

That said, this patch goes back to the original recipe in https://github.com/conan-community/conan-paho-c

And it seems like @uilianries wrote the patch in order to "Install only SSL when required"

https://github.com/conan-community/conan-paho-c/commits/stable/1.3.0/0002-fix-cmake-install.patch

// @icraggs

ghost · 2021-01-03T03:13:57Z

I detected other pull requests that are modifying paho-mqtt-c/all recipe:

Update to paho-mqtt-c 1.3.8. Add -static to static compile libs. #4082

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2021-01-03T03:56:59Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2021-01-03T05:16:23Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2021-01-03T06:20:57Z

All green in build 3 (1f93611dcd748361ec7551f99f525f70d5c15d05)! 😊

paho-mqtt-c/1.3.0: Generated 76 packages. All logs here
paho-mqtt-c/1.3.1: Generated 76 packages. All logs here
paho-mqtt-c/1.3.4: Generated 88 packages. All logs here
paho-mqtt-c/1.3.5: Generated 88 packages. All logs here
paho-mqtt-c/1.3.6: Generated 88 packages. All logs here
paho-mqtt-c/1.3.8: Generated 88 packages. All logs here

prince-chrismc · 2021-01-03T14:58:32Z

It also apears to delete some of the test targets

conan-center-index/recipes/paho-mqtt-c/all/patches/0004-fix-cmake-install.patch

Line 523 in 1f93611

-# Base64 test

Croydon · 2021-01-03T20:14:10Z

True, but they are excluded anyway:

https://github.com/eclipse/paho.mqtt.c/blob/317fb008e1541838d1c29076d2bc5c3e4b6c4f53/src/CMakeLists.txt#L320

https://cmake.org/cmake/help/latest/prop_tgt/EXCLUDE_FROM_ALL.html

a4z

just a note:
the still used pack fix MingGW and OSX, seems to have nothing to do with OSX and MingGW

all it does is removing the -MD flag

 IF(WIN32)
-  ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE -DWIN32_LEAN_AND_MEAN -MD)
+  ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE -DWIN32_LEAN_AND_MEAN)
 ELSEIF(${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
   ADD_DEFINITIONS(-DOSX)
 ENDIF()

so the name is a bit misleading .. ?

(and I wonder if this patch is needed at all ?)

PS:
this seems the way to handle that, but requires cmake 3.15 , what is actually ok, but paho is still on 2.8.??
https://cmake.org/cmake/help/latest/prop_tgt/MSVC_RUNTIME_LIBRARY.html

SpaceIm · 2021-01-09T20:17:58Z

just a note:
the still used pack fix MingGW and OSX, seems to have nothing to do with OSX and MingGW

all it does is removing the -MD flag
 IF(WIN32)
-  ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE -DWIN32_LEAN_AND_MEAN -MD)
+  ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE -DWIN32_LEAN_AND_MEAN)
 ELSEIF(${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
   ADD_DEFINITIONS(-DOSX)
 ENDIF()
so the name is a bit misleading .. ?

(and I wonder if this patch is needed at all ?)

PS:
this seems the way to handle that, but requires cmake 3.15 , what is actually ok, but paho is still on 2.8.??
https://cmake.org/cmake/help/latest/prop_tgt/MSVC_RUNTIME_LIBRARY.html

patch name is misleading, but I'm pretty sure this patch is required. MD shouldn't be forced.

a4z · 2021-01-18T15:36:42Z

I wonder if anyone is successfully using this recipe in the version

I get strange errors,

I do not have them with the 1.3.7 version, that was successfully ignored here , #3834

difference is in the cmake files, here all the patches are missing ....

duplicate symbol '_SHA1_Init' in:
    /Users/a4z/elux/nsdk/.conan/data/paho-mqtt-c/1.3.8/_/_/package/c0e6b2a0b169ea50c3ed9c3ac7f2ea9f2263e4b5/lib/libpaho-mqtt3a.a(SHA1.c.o)
    /Users/a4z/elux/nsdk/.conan/data/openssl/1.1.1i/_/_/package/647afeb69d3b0a2d3d316e80b24d38c714cc6900/lib/libcrypto.a(sha1dgst.o)
duplicate symbol '_SHA1_Final' in:
    /Users/a4z/elux/nsdk/.conan/data/paho-mqtt-c/1.3.8/_/_/package/c0e6b2a0b169ea50c3ed9c3ac7f2ea9f2263e4b5/lib/libpaho-mqtt3a.a(SHA1.c.o)
    /Users/a4z/elux/nsdk/.conan/data/openssl/1.1.1i/_/_/package/647afeb69d3b0a2d3d316e80b24d38c714cc6900/lib/libcrypto.a(sha1dgst.o)
duplicate symbol '_SHA1_Update' in:
    /Users/a4z/elux/nsdk/.conan/data/paho-mqtt-c/1.3.8/_/_/package/c0e6b2a0b169ea50c3ed9c3ac7f2ea9f2263e4b5/lib/libpaho-mqtt3a.a(SHA1.c.o)
    /Users/a4z/elux/nsdk/.conan/data/openssl/1.1.1i/_/_/package/647afeb69d3b0a2d3d316e80b24d38c714cc6900/lib/libcrypto.a(sha1dgst.o)
ld: 3 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

a4z · 2021-01-18T15:44:04Z

also that erorr, what does that mean

duplicate symbol '_MQTTClient_strerror' in:
    /Users/a4z/elux/nsdk/.conan/data/paho-mqtt-c/1.3.8/_/_/package/c0e6b2a0b169ea50c3ed9c3ac7f2ea9f2263e4b5/lib/libpaho-mqtt3c.a(MQTTClient.c.o)
    /Users/a4z/elux/nsdk/.conan/data/paho-mqtt-c/1.3.8/_/_/package/c0e6b2a0b169ea50c3ed9c3ac7f2ea9f2263e4b5/lib/libpaho-mqtt3cs.a(MQTTClient.c.o)

this , libpaho-mqtt3cs.a / libpaho-mqtt3c.a
is super strange ....

@Croydon , do you actually use that package in a project ?

SpaceIm · 2021-01-18T16:20:52Z

libpaho-mqtt3c and libpaho-mqtt3cs shouldn't be packaged together, because we rely on tools.collect_libs(self). Happy ODR violation.

AFAIK, it was the purpose of fix-cmake-install.patch to filter build and installation of libs depending on shared, ssl and asynchronous options. I thought that the behaviour was modified upstream in 1.3.8 since the patch has been removed in this version :s

a4z · 2021-01-18T16:27:40Z

yes, just tested, I built 1.3.8 base on #3834 where I adopted the cmake patches so they work with the new files

I haven't tested all the profile I use, but that one I did work.

I have pretty strong negative feelings for this package, its wasting my time like no other package 😠
This cmake should be fixed upstream, it is a mess. But after the author behaved so bad against me, I will not do that.
But this needs to be fixed upstream , the patches are nearly not reproducible, when the upstream project again does changes with files, it will be hard to adopt the patches , did it once and do not want to do it again

a4z · 2021-01-18T16:50:38Z

I committed a fix
#4293

prince-chrismc · 2021-01-18T16:55:46Z

@a4z I know your pain #4096 took me a week to understand, the team responsible for those projects is not interested upgrading the CMake, there's little we can do 🤷

Based on Space's comments above, we need to use explicit libs to avoid the patches, I might follow up on this next week

Croydon added 3 commits January 3, 2021 03:56

update openssl to 1.1.1i

3b3acc5

nit-picking changes

48a5c11

add paho-mqtt-c/1.3.8

1f93611

Croydon marked this pull request as ready for review January 3, 2021 03:10

This was referenced Jan 3, 2021

[service] Potentially conflicting recipes #3571

Closed

update paho-mqtt-c to 1.3.7 #3834

Closed

conan-center-bot added the Unexpected Error label Jan 3, 2021

Croydon closed this Jan 3, 2021

Croydon reopened this Jan 3, 2021

Croydon closed this Jan 3, 2021

Croydon reopened this Jan 3, 2021

conan-center-bot removed the Unexpected Error label Jan 3, 2021

This was referenced Jan 3, 2021

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

github-actions bot mentioned this pull request Jan 3, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SSE4 requested a review from uilianries January 4, 2021 04:42

SSE4 approved these changes Jan 4, 2021

View reviewed changes

prince-chrismc approved these changes Jan 4, 2021

View reviewed changes

a4z approved these changes Jan 4, 2021

View reviewed changes

This was referenced Jan 4, 2021

Fix issue #3760 #3974

Closed

Update to paho-mqtt-c 1.3.8. Add -static to static compile libs. #4082

Closed

bowb mentioned this pull request Jan 5, 2021

Update to paho-mqtt-c 1.3.8 and paho-mqtt-cpp 1.2.0 #4096

Merged

4 tasks

SpaceIm approved these changes Jan 9, 2021

View reviewed changes

conan-center-bot merged commit 30b6912 into conan-io:master Jan 9, 2021

CroydonBot deleted the paho-mqtt-c-1-3-8 branch January 9, 2021 21:28

a4z mentioned this pull request Jan 18, 2021

redo cmake patching #4293

Merged

4 tasks

prince-chrismc mentioned this pull request Jan 25, 2021

[paho-mqtt-c] Explicit lib list + remove excessive build system patch #4356

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add paho-mqtt-c/1.3.8 #4063

add paho-mqtt-c/1.3.8 #4063

Croydon commented Jan 3, 2021

Croydon commented Jan 3, 2021

ghost commented Jan 3, 2021 •

edited by ghost

Loading

conan-center-bot commented Jan 3, 2021

conan-center-bot commented Jan 3, 2021

conan-center-bot commented Jan 3, 2021

prince-chrismc commented Jan 3, 2021

Croydon commented Jan 3, 2021

a4z left a comment •

edited

Loading

SpaceIm commented Jan 9, 2021

a4z commented Jan 18, 2021

a4z commented Jan 18, 2021

SpaceIm commented Jan 18, 2021 •

edited

Loading

a4z commented Jan 18, 2021

a4z commented Jan 18, 2021

prince-chrismc commented Jan 18, 2021

add paho-mqtt-c/1.3.8 #4063

add paho-mqtt-c/1.3.8 #4063

Conversation

Croydon commented Jan 3, 2021

Croydon commented Jan 3, 2021

ghost commented Jan 3, 2021 • edited by ghost Loading

conan-center-bot commented Jan 3, 2021

conan-center-bot commented Jan 3, 2021

conan-center-bot commented Jan 3, 2021

prince-chrismc commented Jan 3, 2021

Croydon commented Jan 3, 2021

a4z left a comment • edited Loading

Choose a reason for hiding this comment

SpaceIm commented Jan 9, 2021

a4z commented Jan 18, 2021

a4z commented Jan 18, 2021

SpaceIm commented Jan 18, 2021 • edited Loading

a4z commented Jan 18, 2021

a4z commented Jan 18, 2021

prince-chrismc commented Jan 18, 2021

ghost commented Jan 3, 2021 •

edited by ghost

Loading

a4z left a comment •

edited

Loading

SpaceIm commented Jan 18, 2021 •

edited

Loading