cereal: fix CMake imported target #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green in build 1 (
|
allow to link to official cereal imported target through cmake_find_package or cmake_find_package_multi generators
SpaceIm
force-pushed
the
fix/cereal-cmake-target
branch
from
507c448
to
ede9418
Compare
|
All green in build 2 (
|
| def package_id(self): | ||
| self.info.header_only() | ||
| @staticmethod | ||
| def _create_module_official_cmake_targets(module_file, targets): |
There was a problem hiding this comment.
Should this be added as a tool to the client?
There was a problem hiding this comment.
yes, it would be nice
There was a problem hiding this comment.
@SpaceIm It looks a Conan case not a package feature. It would be great opening an issue to talk about, so we can internalize it.
There was a problem hiding this comment.
Yes, there is a suggestion of @madebr conan-io/conan#8338 (comment)
Let's open an issue in https://github.com/conan-io/conan
prince-chrismc
approved these changes
Jan 14, 2021
SSE4
approved these changes
Jan 15, 2021
uilianries
approved these changes
Jan 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: cereal/all
conan-center hook activated.
first attempt to provide non namespaced CMake imported target in CCI recipe. Based on tests of @jgsogo conan-io/conan#8338