[opencv/4.x.x] fix CMake imported targets + bump dependencies #4267

SpaceIm · 2021-01-15T01:14:32Z

Specify library name and version: opencv/4.x.x

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

OpenCV imported targets are not namespaced

SpaceIm · 2021-01-15T01:37:56Z

Actually, it doesn't work yet. I guess that build modules are called before targets are defined (but it works when the recipe doesn't use components).

conan-center-bot · 2021-01-15T01:56:54Z

Some configurations of 'opencv/4.5.0' failed in build 2 (e3cf2811a19cc012f15cc9b462a0f4ac88bf1335):

Linux x86_64, Debug, clang 8, libstdc++ . Options: opencv:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 16, MTd. Options: opencv:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: opencv:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: opencv:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MDd. Options: opencv:shared-False
Access to all the logs

ghost · 2021-01-15T18:00:46Z

I detected other pull requests that are modifying opencv/4.x recipe:

Fix opencv on Apple M1 #4536

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

SpaceIm · 2021-01-26T13:58:46Z

Let's wait conan 1.33.0 in CI.

conan-center-bot · 2021-02-12T17:10:01Z

Failure in build 4 (35ae47a048f66febecd6b2999940075cdd97fba5):

opencv/4.1.2@:
An unexpected error happened and has been reported
opencv/4.5.1@:
An unexpected error happened and has been reported
opencv/4.5.0@:
An unexpected error happened and has been reported

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-12T17:15:25Z

Failure in build 5 (35ae47a048f66febecd6b2999940075cdd97fba5):

opencv/4.5.0@:
An unexpected error happened and has been reported
opencv/4.1.2@:
An unexpected error happened and has been reported
opencv/4.5.1@:
An unexpected error happened and has been reported

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-12T18:01:02Z

Failure in build 6 (35ae47a048f66febecd6b2999940075cdd97fba5):

opencv/4.1.2@:
An unexpected error happened and has been reported
opencv/4.5.0@:
An unexpected error happened and has been reported
opencv/4.5.1@:
An unexpected error happened and has been reported

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-12T18:28:08Z

Failure in build 7 (35ae47a048f66febecd6b2999940075cdd97fba5):

opencv/4.1.2@:
An unexpected error happened and has been reported
opencv/4.5.0@:
An unexpected error happened and has been reported
opencv/4.5.1@:
An unexpected error happened and has been reported

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

jgsogo · 2021-02-12T18:31:41Z

This is very weird. The CI is identifying 35ae47... as the latest commit when there is a merge afterward. The problem is that using the previous commit there is a conflict with master and it fails.

I would like to have a look at this issue and try to understand why this is happening, but I'm not working this weekend 😅 ... if you want to keep working on this PR I think the best/easiest solution is to push an empty commit and the CI should start to use it.

…center-index into fix/opencv4-cmake-targets

SpaceIm · 2021-02-12T18:59:56Z

Thanks @jgsogo, I've pushed an empty commit

conan-center-bot · 2021-02-12T21:12:28Z

All green in build 9 (20af42464f4feeafc4b11f15aac464aeaecfe52f):

opencv/4.1.2@:
All packages built successfully! (All logs)
opencv/4.5.1@:
All packages built successfully! (All logs)
opencv/4.5.0@:
All packages built successfully! (All logs)

SpaceIm · 2021-02-12T21:24:15Z

Well, it was a typo. So we can create non namespaced imported targets for recipes with components, even before conan 1.33.0 :)

SpaceIm · 2021-02-12T21:31:21Z

@madebr @prince-chrismc @ericLemanissier @uilianries @SSE4 Could you review please?

uilianries

LGTM!

prince-chrismc · 2021-02-13T01:59:39Z

recipes/opencv/4.x/conanfile.py

+        )
+
+    @staticmethod
+    def _create_cmake_module_alias_targets(module_file, targets):


I dislike how much this is being copied around, it really need to be added to Conan

Do there exist examples of this pattern for creating imported executables?

I tried something in geographiclib but canceled the modification: ec87edc

imported executables will be implemented in conan.

SpaceIm added 4 commits January 15, 2021 01:58

don't create alias component if same name than target

d2890b7

fix CMake imported targets

44c7b17

OpenCV imported targets are not namespaced

bump dependencies

4255e1a

add builddirs and build_modules

e3cf281

conan-center-bot added the Failed label Jan 15, 2021

SpaceIm mentioned this pull request Jan 15, 2021

[test] Add test creating a target without namespaces (CMake) conan-io/conan#8338

Merged

SpaceIm marked this pull request as draft January 15, 2021 16:35

This was referenced Jan 15, 2021

[service] Potentially conflicting recipes #3571

Closed

opencv/4.1.2 #4270

Merged

This was referenced Feb 5, 2021

opencv 4.x: bump dependencies #4489

Merged

Fix opencv on Apple M1 #4536

Merged

SpaceIm added 2 commits February 12, 2021 17:43

fix typo

35ae47a

Merge branch 'master' into fix/opencv4-cmake-targets

d30afaa

conan-center-bot added the Unexpected Error label Feb 12, 2021

SpaceIm marked this pull request as ready for review February 12, 2021 17:12

SpaceIm closed this Feb 12, 2021

SpaceIm reopened this Feb 12, 2021

conan-center-bot added Unexpected Error and removed Unexpected Error labels Feb 12, 2021

SpaceIm closed this Feb 12, 2021

SpaceIm reopened this Feb 12, 2021

conan-center-bot added Unexpected Error and removed Unexpected Error labels Feb 12, 2021

SpaceIm added 2 commits February 12, 2021 19:58

empty commit

16819f6

Merge branch 'fix/opencv4-cmake-targets' of github.com:SpaceIm/conan-…

e79a597

…center-index into fix/opencv4-cmake-targets

empty commit

20af424

conan-center-bot removed Unexpected Error Failed labels Feb 12, 2021

github-actions bot mentioned this pull request Feb 12, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries approved these changes Feb 12, 2021

View reviewed changes

prince-chrismc reviewed Feb 13, 2021

View reviewed changes

prince-chrismc approved these changes Feb 13, 2021

View reviewed changes

madebr approved these changes Feb 13, 2021

View reviewed changes

conan-center-bot merged commit 4efff19 into conan-io:master Feb 13, 2021

SpaceIm deleted the fix/opencv4-cmake-targets branch February 13, 2021 07:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[opencv/4.x.x] fix CMake imported targets + bump dependencies #4267

[opencv/4.x.x] fix CMake imported targets + bump dependencies #4267

SpaceIm commented Jan 15, 2021

SpaceIm commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

ghost commented Jan 15, 2021 •

edited by ghost

Loading

SpaceIm commented Jan 26, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

jgsogo commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

uilianries left a comment

prince-chrismc Feb 13, 2021

madebr Feb 13, 2021

SpaceIm Feb 15, 2021

[opencv/4.x.x] fix CMake imported targets + bump dependencies #4267

[opencv/4.x.x] fix CMake imported targets + bump dependencies #4267

Conversation

SpaceIm commented Jan 15, 2021

SpaceIm commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

ghost commented Jan 15, 2021 • edited by ghost Loading

SpaceIm commented Jan 26, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

jgsogo commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

conan-center-bot commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

SpaceIm commented Feb 12, 2021

uilianries left a comment

Choose a reason for hiding this comment

prince-chrismc Feb 13, 2021

Choose a reason for hiding this comment

madebr Feb 13, 2021

Choose a reason for hiding this comment

SpaceIm Feb 15, 2021

Choose a reason for hiding this comment

ghost commented Jan 15, 2021 •

edited by ghost

Loading