Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup boost recipe package_info by caching dependencies file #4319

Merged

Conversation

mathbunnyru
Copy link
Contributor

Specify library name and version: boost/all

Fix: #4203

The file with dependencies was read on each call to self._dependencies.
It never changes, so I decided to cache it, and it gave a good speedup and 6 seconds waiting during package_info is gone.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@TheStormN
Copy link
Contributor

TheStormN commented Jan 20, 2021

Is the CI broken or something? Before I was able to see the status of the builds...

P.S. @mathbunnyru you also need to fill the checkboxes. :)

@mathbunnyru
Copy link
Contributor Author

Is the CI broken or something? Before I was able to see the status of the builds...

P.S. @mathbunnyru you also need to fill the checkboxes. :)

Filling checkboxes is not necessary, believe me :)
I don't think many check them.
I think they are made for the newcomers, who want to create first PR.

@madebr
Copy link
Contributor

madebr commented Jan 20, 2021

Filling checkboxes is not necessary, believe me :)
I don't think many check them.
I think they are made for the newcomers, who want to create first PR.

@mathbunnyru is a bad boy, living by his own rules 🤣
Great pr btw, I didn't think that the file was reread and reparsed that many times in package_info.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (b7d9a00739975986da7a43b28983197f71bb9f9d)! 😊

@prince-chrismc
Copy link
Contributor

Is the CI broken or something? Before I was able to see the status of the builds...

You need to check the messages posted by the bot #4319 (comment)

@SSE4
Copy link
Contributor

SSE4 commented Jan 21, 2021

check-boxes are just more or less a reminder for contributors, it's not required to mark them, it's just to not forget about running these steps

@TheStormN
Copy link
Contributor

Is the CI broken or something? Before I was able to see the status of the builds...

You need to check the messages posted by the bot #4319 (comment)

Sure, but before I was able to directly open them in the CI, which gives you the information in much more comfortable variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] boost/1.75.0: slow no-op
7 participants