Add botan/2.12.1 #437

hrantzsch · 2019-12-09T08:53:03Z

Adds a recipe for Botan based on the bincrafters/conan-botan recipe.

Specify library name and version: botan/2.12.1

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

claassistantio · 2019-12-09T08:53:52Z

All committers have signed the CLA.

conan-center-bot · 2019-12-09T08:56:25Z

botan/2.12.1:

Error processing recipe: Linux x86_64, Release, gcc 6, libstdc++ . Options: botan:shared-True
Unexpected error happened:

ERROR: botan/2.12.1: Error in config_options() method, line 75
	self.check_cxx_abi_settings()
while calling 'check_cxx_abi_settings', line 277
	'Using Botan with GCC > 5 on Linux requires '
	ConanException: Using Botan with GCC > 5 on Linux requires "compiler.libcxx=libstdc++11"

conan-center-bot · 2019-12-09T11:38:19Z

Recipe syntax error:

WARN: Remotes registry file missing, creating default one in /home/conan/.conan/remotes.json
ERROR: Error loading conanfile at '/home/conan/workspace/conan-center-pull-request_PR-437/recipes/botan/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/conan-center-pull-request_PR-437/recipes/botan/all/conanfile.py
  File "/opt/pyenv/versions/3.7.1/lib/python3.7/site-packages/conans/model/ref.py", line 197, in loads
    name, version, user, channel, revision = get_reference_fields(text)
  File "/opt/pyenv/versions/3.7.1/lib/python3.7/site-packages/conans/model/ref.py", line 66, in get_reference_fields
    el1, el2 = _split_pair(arg_reference, "/") or (arg_reference, None)
  File "/opt/pyenv/versions/3.7.1/lib/python3.7/site-packages/conans/model/ref.py", line 18, in _split_pair
    raise ConanException("The reference has too many '{}'".format(split_char))
conans.errors.ConanException: The reference has too many '/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/pyenv/versions/3.7.1/lib/python3.7/site-packages/conans/client/loader.py", line 314, in _parse_conanfile
    loaded = imp.load_source(module_id, conan_file_path)
  File "/opt/pyenv/versions/3.7.1/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/conan-center-pull-request_PR-437/recipes/botan/all/conanfile.py", line 325
    return compiler == 'gcc' and version > 5 and compiler.libcxx != 'libstdc++11':
                                                                                 ^
SyntaxError: invalid syntax

conan-center-bot · 2019-12-09T11:50:55Z

botan/2.12.1:

Error processing recipe: Linux x86_64, Debug, clang 3.9, libstdc++ . Options: botan:shared-True
Unexpected error happened:

ERROR: botan/2.12.1: Error in configure() method, line 57
	self.check_cxx_abi_settings()
while calling 'check_cxx_abi_settings', line 283
	'Using Botan with Clang on Linux requires either '
	ConanException: Using Botan with Clang on Linux requires either "compiler.libcxx=libstdc++11" or "compiler.libcxx=libc++"

conan-center-bot · 2019-12-09T12:22:10Z

Some configurations of 'botan/2.12.1' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: botan:shared-True
Access to all the logs

recipes/botan/all/conanfile.py

recipes/botan/all/test_package/conanfile.py

recipes/botan/all/conanfile.py

uilianries · 2019-12-09T13:38:56Z

recipes/botan/all/conanfile.py

+            self.cpp_info.libs.extend(["ws2_32", "Crypt32"])
+
+        self.cpp_info.libdirs = ['lib']
+        self.cpp_info.bindirs = ['lib', 'bin']


why lib is bindir?

This is for Windows. Otherwise botan.dll is not found in PATH.

windows dlls should be placed in the bin directory

Just to be clear, you're saying it's fine as it is, right?

The problem here is that the lib folder should not be part of cpp_info.bindirs as no binaries should be placed there, only bin folder should contain binaries (executables and dlls)

Thanks for the clarification, got it now. I'm still trying to figure out how to tell Botan's build system to do so. There's a --libdir=bin as an option, but it will place both botan.dll and botan.lib in the bin folder, which results in the test-package not finding botan.lib anymore.

I've added a patch for Botan to place the DLL in the binary directory rather
than the library dir. That should work and we'll try to get it upstream in the
next Botan version.

recipes/botan/all/conanfile.py

recipes/botan/all/test_package/CMakeLists.txt

recipes/botan/all/conanfile.py

conan-center-bot · 2019-12-10T07:07:58Z

botan/2.12.1:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: botan:shared-True
Unexpected error happened:

ERROR: botan/2.12.1: Error in configure() method, line 51
	if self._needs_cxx_abi_workaround:
while calling '_needs_cxx_abi_workaround', line 310
	version = Version(compiler.version)
	ConanException: 'settings.compiler.version.strip' doesn't exist for '5'
'settings.compiler.version' possible configurations are none

Co-Authored-By: Uilian Ries <uilianries@gmail.com> Co-Authored-By: Michael "Croydon" Keck <git@cr0ydon.com>

conan-center-bot · 2019-12-10T07:47:06Z

Some configurations of 'botan/2.12.1' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: botan:shared-True
Access to all the logs

Raise ConanInvalidConfiguration rather than ConanException if the libcxx setting is not supported for this compiler

recipes/botan/all/conanfile.py

conan-center-bot · 2019-12-10T08:21:19Z

Some configurations of 'botan/2.12.1' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: botan:shared-False
You are depending on 'jom_installer/1.1.2@bincrafters/stable' but it is not in the repository

Replicates bincrafters/conan-botan#19

conan-center-bot · 2019-12-10T08:43:19Z

Some configurations of 'botan/2.12.1' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: botan:shared-False
You are depending on 'jom_installer/1.1.2@bincrafters/stable' but it is not in the repository

See also randombit/botan#2142

conan-center-bot · 2019-12-10T09:14:57Z

Some configurations of 'botan/2.12.1' have failed:

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: botan:shared-False
Access to all the logs
Macos x86_64, Release, apple-clang 9.1, libc++ . Options: botan:shared-False
Access to all the logs

hrantzsch · 2019-12-10T11:16:49Z

We have an issue linking the test-package on macOS for static builds. It seems CoreFoundation is not correctly added to the linker call.

It looks like it is related to this issue another recipe had in the past. However, the reason over there was found to be an outdated Conan version.

This is the related fix in Conan I guess: conan-io/conan#6003.

Help is greatly appreciated 😉
Also, can I see what version of Conan the build job used anywhere?

recipes/botan/all/conanfile.py

Co-Authored-By: Daniel <danimanzaneque@gmail.com>

conan-center-bot · 2019-12-20T13:10:42Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

recipes/botan/all/conanfile.py

Co-Authored-By: René Meusel <github@renemeusel.de>

conan-center-bot · 2019-12-26T07:36:22Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

danimtb

This recipe looks complex as the library seems to have different options and ways to build it. Please review the option of the recipe to reduce them and reduce complexity and try to make it as uniform as possible.

recipes/botan/all/conanfile.py

danimtb · 2019-12-26T12:18:15Z

recipes/botan/all/conanfile.py

+            self.cpp_info.libs.extend(["ws2_32", "Crypt32"])
+
+        self.cpp_info.libdirs = ['lib']
+        self.cpp_info.bindirs = ['lib', 'bin']


windows dlls should be placed in the bin directory

…h_*'

conan-center-bot · 2019-12-27T07:50:08Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

recipes/botan/all/conanfile.py

conan-center-bot · 2019-12-31T04:40:51Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

Add a patch for Botan's build system to place the DLL in the binary dir rather than the library dir.

conan-center-bot · 2020-01-03T10:31:07Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

recipes/botan/all/conanfile.py

conan-center-bot · 2020-01-03T11:25:54Z

All green! 😊

botan/2.12.1: Generated 82 packages. All logs here

reneme · 2020-01-03T14:47:50Z

Thanks a lot everybody for the effort to bring botan in here!
One question, though: Who's responsible to deprecate the bincrafters version of this recipe? Should I do that manually, via a pull request, or is there a different process?

hrantzsch · 2020-01-03T14:57:09Z

Thank you all for your support!

danimtb · 2020-01-03T15:17:18Z

cc/ @SSE4 @Croydon

Croydon · 2020-01-04T23:07:00Z

It's mostly me doing this. I'm watching the merges into CCI so you don't need to ping me for this, but since it is a manual process there will be delays 😄

add recipe for botan/2.12.1

a6230a2

conan-center-bot added the Failed label Dec 9, 2019

get requirements from conan-center-index

e1bf2b4

hrantzsch force-pushed the recipe/botan branch from 77bf0a2 to 8c9e04e Compare December 9, 2019 11:47

uilianries requested changes Dec 9, 2019

View reviewed changes

Croydon reviewed Dec 9, 2019

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed Dec 9, 2019

View reviewed changes

recipes/botan/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

Croydon reviewed Dec 9, 2019

View reviewed changes

recipes/botan/all/test_package/CMakeLists.txt Show resolved Hide resolved

Croydon reviewed Dec 9, 2019

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

Croydon mentioned this pull request Dec 9, 2019

FIX: explicitly set -mmacosx-version-min and -isysroot when appropriate bincrafters/conan-botan#19

Merged

Apply suggestions from code review

58e0269

Co-Authored-By: Uilian Ries <uilianries@gmail.com> Co-Authored-By: Michael "Croydon" Keck <git@cr0ydon.com>

hrantzsch force-pushed the recipe/botan branch from 3e87052 to 109868f Compare December 10, 2019 07:38

hrantzsch added 2 commits December 10, 2019 15:13

ConanInvalidConfiguration for libcxx issues

182c313

Raise ConanInvalidConfiguration rather than ConanException if the libcxx setting is not supported for this compiler

remove compatibility workaround for boost < 1.69

df059bb

hrantzsch force-pushed the recipe/botan branch from 109868f to df059bb Compare December 10, 2019 08:14

hrantzsch commented Dec 10, 2019

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

FIX: explicitly set -mmacosx-version-min and -isysroot when appropriate

96fc1f7

Replicates bincrafters/conan-botan#19

no longer require jom

a573090

See also randombit/botan#2142

danimtb assigned SSE4 Dec 10, 2019

conan-center-bot added the Failed label Dec 20, 2019

This comment has been minimized.

Sign in to view

danimtb reviewed Dec 20, 2019

View reviewed changes

recipes/botan/all/conanfile.py Show resolved Hide resolved

Add topics

97ba218

Co-Authored-By: Daniel <danimanzaneque@gmail.com>

conan-center-bot removed the Failed label Dec 20, 2019

reneme reviewed Dec 23, 2019

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

add tls topic, fix typo

93bd8bd

Co-Authored-By: René Meusel <github@renemeusel.de>

danimtb requested changes Dec 26, 2019

View reviewed changes

hrantzsch added 2 commits December 27, 2019 14:15

remove options 'quiet' and 'debug_info'

2641941

rename options 'bzip2', 'sqlite3', 'zlib', 'boost', 'openssl' -> 'wit…

ef24bfd

…h_*'

uilianries requested changes Dec 30, 2019

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

hrantzsch added 2 commits December 31, 2019 11:05

extract compiler settings validation

e556ee1

sanitize amalgamation options in configure()

fcb92be

remove 'lib' from bindirs

ad5b88a

Add a patch for Botan's build system to place the DLL in the binary dir rather than the library dir.

danimtb reviewed Jan 3, 2020

View reviewed changes

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

recipes/botan/all/conanfile.py Outdated Show resolved Hide resolved

remove setting of bin/lib dirs, simplify mingw check

1f06473

danimtb assigned danimtb and unassigned SSE4 Jan 3, 2020

danimtb merged commit da7399e into conan-io:master Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add botan/2.12.1 #437

Add botan/2.12.1 #437

hrantzsch commented Dec 9, 2019

claassistantio commented Dec 9, 2019 •

edited

Loading

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

uilianries Dec 9, 2019

hrantzsch Dec 10, 2019

danimtb Dec 26, 2019

hrantzsch Dec 27, 2019

danimtb Dec 27, 2019

hrantzsch Dec 30, 2019

hrantzsch Jan 3, 2020

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

hrantzsch commented Dec 10, 2019

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Dec 20, 2019

conan-center-bot commented Dec 26, 2019

danimtb left a comment

danimtb Dec 26, 2019

conan-center-bot commented Dec 27, 2019

conan-center-bot commented Dec 31, 2019

conan-center-bot commented Jan 3, 2020

conan-center-bot commented Jan 3, 2020

reneme commented Jan 3, 2020

hrantzsch commented Jan 3, 2020

danimtb commented Jan 3, 2020

Croydon commented Jan 4, 2020

Add botan/2.12.1 #437

Add botan/2.12.1 #437

Conversation

hrantzsch commented Dec 9, 2019

claassistantio commented Dec 9, 2019 • edited Loading

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

conan-center-bot commented Dec 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

hrantzsch commented Dec 10, 2019

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Dec 20, 2019

conan-center-bot commented Dec 26, 2019

danimtb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 27, 2019

conan-center-bot commented Dec 31, 2019

conan-center-bot commented Jan 3, 2020

conan-center-bot commented Jan 3, 2020

reneme commented Jan 3, 2020

hrantzsch commented Jan 3, 2020

danimtb commented Jan 3, 2020

Croydon commented Jan 4, 2020

claassistantio commented Dec 9, 2019 •

edited

Loading