-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zeromq/4.3.2 recipe #489
Conversation
Some configurations of 'zeromq/4.3.2' have failed:
|
Some configurations of 'zeromq/4.3.2' have failed:
|
Some configurations of 'zeromq/4.3.2' have failed:
|
All green! 😊
|
All green in build 5 (
|
recipes/libzmq/all/conanfile.py
Outdated
|
||
|
||
class LibZMQConan(ConanFile): | ||
name = "libzmq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why libzmq and not zeromq? Is there any idea for zeromq as installer package? The folder name is zeromq btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning is that the name of the project is libzma: https://github.com/zeromq/libzmq/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough!
I see vcpkg names it zeromq... we will need some consensus here @Croydon @Minimonium |
There are inconsistencies in how they name their own releases on various platforms, both names are used: https://zeromq.org/download/ It's better to have the name parity in package managers - better discoverability for users as per #52 On the other hand, their target's name is |
I've renamed the package to zeromq. |
All green in build 6 (
|
So this means that there would be no "transparent integration" as the target name will be different, right? |
@danimtb The upstream project doesn't seem to support proper targets with alias support. |
Ok, so I think the name is ok as is right now |
All green in build 7 (
|
@uilianries Can I have a rebuild? |
@madebr I just restarted the build now. Let's wait. |
All green in build 12 (
|
All green in build 13 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting several changes related to the test_package
:
- Consume it using
cmake_find_package
so we realize what the name of the target is. (We will also needcmake
generator andconan_basic_setup()
call in order to adjust compiler flags... the toolchain should arrive sooner than later, but meanwhile, it is needed) - The
WITH_LIBSODIUM
definition should be added to thecpp_info
, Conan will add it to the target and apply it to the test executable
That's a bit of news for me. Could you elaborate? |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Nothing new, in the |
It's just that I have a few test packages here without it (only with the Thanks for the information! |
Most of the time the test_package is so simple that it compiles without it, but I prefer to have it there to avoid some copy/paste issues 😄 |
All green in build 14 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Specify library name and version: zeromq/4.3.2
conan-center hook activated.