Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conanized zlib-ng 2.0.0 #5264

Merged
merged 17 commits into from
May 4, 2021
Merged

Conversation

tomas-krupa
Copy link
Contributor

@tomas-krupa tomas-krupa commented Apr 19, 2021

Specify library name and version: zlib-ng/2.0.0

zlib data compression library for the next generation systems

Author: Hans Kristian Rosbach aka Dead2
Homepage: https://github.com/zlib-ng/zlib-ng


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: tkrupa <tomas@krupa.hu>
@tomas-krupa tomas-krupa mentioned this pull request Apr 19, 2021
4 tasks
@conan-center-bot

This comment has been minimized.

Signed-off-by: tkrupa <tomas@krupa.hu>
@conan-center-bot

This comment has been minimized.

recipes/zlib-ng/all/conanfile.py Outdated Show resolved Hide resolved
recipes/zlib-ng/all/conanfile.py Outdated Show resolved Hide resolved
recipes/zlib-ng/all/conanfile.py Outdated Show resolved Hide resolved
recipes/zlib-ng/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/zlib-ng/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/zlib-ng/all/test_package/enough.c Outdated Show resolved Hide resolved
tomas-krupa and others added 3 commits April 23, 2021 10:09
Signed-off-by: tkrupa <tomas@krupa.hu>
Test package following common template

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Signed-off-by: tkrupa <tomas@krupa.hu>
@conan-center-bot

This comment has been minimized.

Signed-off-by: tkrupa <tomas@krupa.hu>
@conan-center-bot

This comment has been minimized.

tomas-krupa and others added 3 commits April 24, 2021 23:07
Signed-off-by: tkrupa <tomas@krupa.hu>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: tkrupa <tomas@krupa.hu>
@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Apr 24, 2021
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@tomas-krupa Consider tomas-krupa#1

I see many points to be improved, also your recipe is not complete yet, defines are missing.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go

recipes/zlib-ng/all/conandata.yml Outdated Show resolved Hide resolved
recipes/zlib-ng/all/test_package/test_package.c Outdated Show resolved Hide resolved
recipes/zlib-ng/config.yml Outdated Show resolved Hide resolved
tomas-krupa and others added 3 commits April 27, 2021 14:09
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few issues with the targets

recipes/zlib-ng/all/conanfile.py Outdated Show resolved Hide resolved
recipes/zlib-ng/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

tomas-krupa and others added 2 commits April 28, 2021 07:43
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot

This comment has been minimized.

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 14 (f19528cc6738a5d7ade76e1438cd24a375592883):

  • zlib-ng/2.0.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot requested a review from SSE4 May 3, 2021 12:00
@conan-center-bot conan-center-bot requested a review from danimtb May 4, 2021 11:57
@danimtb
Copy link
Member

danimtb commented May 4, 2021

ping @uilianries, I think you need to approve to update previous review

@prince-chrismc
Copy link
Contributor

prince-chrismc commented May 4, 2021

It should be good to go 🤞

prince-chrismc/conan-center-index-pending-review#1 Has this in ready to merge 🎉

@conan-center-bot conan-center-bot merged commit 3884c71 into conan-io:master May 4, 2021
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
* conanized zlib-ng 2.0.0

Signed-off-by: tkrupa <tomas@krupa.hu>

* removed win static lib suffix

Signed-off-by: tkrupa <tomas@krupa.hu>

* conanized useful cmake options

Signed-off-by: tkrupa <tomas@krupa.hu>

* Update recipes/zlib-ng/all/test_package/conanfile.py

Test package following common template

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* reduced test package

Signed-off-by: tkrupa <tomas@krupa.hu>

* test_package depending on zlib.ng explicitely

Signed-off-by: tkrupa <tomas@krupa.hu>

* using upstream cmake install

Signed-off-by: tkrupa <tomas@krupa.hu>

* Update recipes/zlib-ng/all/test_package/test_package.c

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* using cmake wrapper

Signed-off-by: tkrupa <tomas@krupa.hu>

* Improve zlib-ng

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/zlib-ng/all/conandata.yml

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/zlib-ng/config.yml

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/zlib-ng/all/test_package/test_package.c

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/zlib-ng/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/zlib-ng/all/test_package/CMakeLists.txt

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/zlib-ng/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants