Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for immer #5522

Merged
merged 4 commits into from
May 16, 2021
Merged

Add a recipe for immer #5522

merged 4 commits into from
May 16, 2021

Conversation

rileylev
Copy link
Contributor

Specify library name and version: immer/0.6.2

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@@ -1,4 +0,0 @@
sources:
"0.12.1":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally removed some files in refl-cpp.
Please undo this 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noooooooo

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@LHLaurini LHLaurini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you have removed the recipe for refl-cpp and created one for immer in the wrong directory (/ instead of /recipes). Please fix that.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@LHLaurini LHLaurini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details. Other than that, looks good. Also, avoid force-pushing unless necessary, it can erase the history.

recipes/immer/all/conandata.yml Show resolved Hide resolved
recipes/immer/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Luiz Henrique Laurini <lhlaurini@hotmail.com>
@conan-center-bot

This comment has been minimized.

@LHLaurini
Copy link
Contributor

Guess that was too old. Try increasing the GCC version a little.

@conan-center-bot

This comment has been minimized.

@LHLaurini
Copy link
Contributor

Please, also accept this.

Copy link
Contributor

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conan-center-bot
Copy link
Collaborator

All green in build 8 (bf95be94effc0402dd02faa54ca8dedcceb2a8e1):

  • immer/0.6.2@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries May 16, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants