Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore .devcontainer #5606

Merged
merged 1 commit into from
Jun 23, 2021
Merged

ignore .devcontainer #5606

merged 1 commit into from
Jun 23, 2021

Conversation

dvirtz
Copy link
Contributor

@dvirtz dvirtz commented May 23, 2021

.devcontainer is a folder used by VSCode for container development


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Changes not allowed in build 1:

[.gitignore]

Split them in several pull requests if you are making changes in more than one folder.

@Croydon
Copy link
Contributor

Croydon commented May 23, 2021

Is this an extension or some default feature? Makes me wonder why it isn't a subdirectory of .vscode

@dvirtz
Copy link
Contributor Author

dvirtz commented May 23, 2021

@SSE4 SSE4 requested a review from uilianries May 24, 2021 11:00
@dvirtz
Copy link
Contributor Author

dvirtz commented May 30, 2021

can this be merged?

@dvirtz
Copy link
Contributor Author

dvirtz commented Jun 15, 2021

@uilianries a kind reminder

@prince-chrismc
Copy link
Contributor

The CCI team will need to merge this manually, not sure who has permissions

@uilianries
Copy link
Member

@jgsogo @danimtb We need to merge manually here, because is a git file, but as CI failed, the button is disabled. Is there another internal alternative?

@jgsogo
Copy link
Contributor

jgsogo commented Jun 23, 2021

Ok, let's merge it manually 🚀 (it will probably fail in master)

@jgsogo jgsogo merged commit 5bdf8df into conan-io:master Jun 23, 2021
@dvirtz dvirtz deleted the ignore-devcontainer branch June 23, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants