Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double-conversion: regenerate binaries #5702

Closed
wants to merge 1 commit into from
Closed

double-conversion: regenerate binaries #5702

wants to merge 1 commit into from

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: double-conversion/*

this is an investigation on #5691 (comment), to see if double-conversion.lib is actually generated or not for package hash df81ad20137149d7a51276fd3e24009b45e5964a (MSVC14 release MT)

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ericLemanissier ericLemanissier mentioned this pull request May 31, 2021
Merged
4 tasks
@github-actions github-actions bot mentioned this pull request May 31, 2021
Open
@prince-chrismc
Copy link
Contributor

Ci seems stuck

@conan-center-bot
Copy link
Collaborator

All green in build 2 (8762fa9318720ef945bad92dc37e6c3aea0d52eb):

  • double-conversion/3.1.5@:
    All packages built successfully! (All logs)

  • double-conversion/3.1.4@:
    All packages built successfully! (All logs)

@ericLemanissier ericLemanissier marked this pull request as draft June 1, 2021 07:55
@madebr
Copy link
Contributor

madebr commented Jun 1, 2021

I think this needs

required_conan_version = ">=1.33.0"

at the top

@ericLemanissier
Copy link
Contributor Author

the error in #5691 (comment) was solved by restarting the build, so this regeneration does not seem necessary

@ericLemanissier ericLemanissier deleted the patch-1 branch June 2, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericLemanissier @prince-chrismc @conan-center-bot @madebr