Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: raise conan libs priority vs system libs #6019

Merged
merged 3 commits into from
Jun 26, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jun 22, 2021

Specify library name and version: qt/5.15.2

fixes #5824
fixes #5931


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jun 22, 2021

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor

worked for me locally

AndreyMlashkin
AndreyMlashkin previously approved these changes Jun 22, 2021
@conan-center-bot

This comment has been minimized.

AndreyMlashkin
AndreyMlashkin previously approved these changes Jun 22, 2021
uilianries
uilianries previously approved these changes Jun 23, 2021
@AndreyMlashkin
Copy link
Contributor

@SpaceIm @CAMOBAP @ruilvo @Renari
Please approve somebody

SpaceIm
SpaceIm previously approved these changes Jun 24, 2021
@ruilvo
Copy link
Contributor

ruilvo commented Jun 24, 2021

@AndreyMlashkin I'm not a conan dev hahaha My approvals do nothing. Also, there's a feature on the right sidebar to ask for reviews :)

edit: and also, notice the bot writes things pending review here, so the devs will notice them :)

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jun 24, 2021

@AndreyMlashkin the same to me, I haven't permissions to approve

qmake already links to qt libraries
@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

trigger CI

@conan-center-bot
Copy link
Collaborator

All green in build 4 (a0c3c3fb3e628d4a925f127dce83749557dc633f):

  • qt/5.15.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 39a9ad7 into conan-io:master Jun 26, 2021
@CroydonBot CroydonBot deleted the qt branch June 26, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants