Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spirv-tools to 2021.2 #6144

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Bump spirv-tools to 2021.2 #6144

merged 1 commit into from
Jul 5, 2021

Conversation

espositofulvio
Copy link
Contributor

Specify library name and version: spirv-tools/2021.2

This pull request updates spirv-tools to 2021.2


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@espositofulvio
Copy link
Contributor Author

@prince-chrismc I'm not sure what's happening but two old versions are failing to build even though my changes just add a new version. Could someone check what's the specific error?

@prince-chrismc
Copy link
Contributor

When you change a recipe all the versions are rebuilt to ensure things are in sync.

Given everything passed in the logs it might be a random issue in the backend... the CCI infra team might comment on what...

For now...
You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

@jgsogo
Copy link
Contributor

jgsogo commented Jul 4, 2021

There are some errors that we label as random. They happen from time to time. Probably they are not random, but we don't have time to investigate (and implement) all of them, usually, there are other priorities 😞

In this case, the two builds have failed with this error:

org.jenkinsci.plugins.workflow.cps.CpsCompilationErrorsException: startup failed:
General error during conversion: java.util.ConcurrentModificationException

java.util.ConcurrentModificationException

I know sometimes it can be annoying, we might eventually try to fix this specific error, but there will always be something unexpected. Triggering the build again is usually the (easiest) way to go.

@espositofulvio
Copy link
Contributor Author

Hi @jgsogo, thanks for your reply, I've just started using Conan and don't know in depth all the CI build process, but thanks for all your effort, I do think Conan is really wonderful piece of software and I hope to contribute more 😊. I restarted the build as both you and Chris suggested.
Thanks again!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

Do not continue restarting there might be something wrong

@espositofulvio
Copy link
Contributor Author

I thought it was only a matters of the right time. I'll hold off then

@prince-chrismc
Copy link
Contributor

It's still building so we might actually be lucky!

@conan-center-bot
Copy link
Collaborator

All green in build 5 (3093bad9162e288d55eeddec288b0481d964518e):

  • spirv-tools/2021.2@:
    All packages built successfully! (All logs)

  • spirv-tools/v2020.5@:
    All packages built successfully! (All logs)

  • spirv-tools/2020.5@:
    All packages built successfully! (All logs)

  • spirv-tools/2020.3@:
    All packages built successfully! (All logs)

  • spirv-tools/v2020.3@:
    All packages built successfully! (All logs)

  • spirv-tools/2019.2@:
    All packages built successfully! (All logs)

  • spirv-tools/v2019.2@:
    All packages built successfully! (All logs)

@AndreyMlashkin
Copy link
Contributor

@uilianries, please review.
Many other recipes are depending on this one

@prince-chrismc
Copy link
Contributor

prince-chrismc commented Jul 5, 2021

@AndreyMlashkin Please be patient! there's lot of PR's that need attention ❤️ We'll get there soon!

EDIT:

Also thank you I noticed I broken prince-chrismc/conan-center-index-pending-review#1 with prince-chrismc/conan-center-index-pending-review@fbd9c10 🤢 since nothing was marked in review

@espositofulvio
Copy link
Contributor Author

@prince-chrismc I'm still learning a bit about the review process, so my question is: am I allowed to review and approve pull requests from other contributors?

@prince-chrismc
Copy link
Contributor

@espositofulvio Yes! it's not counted towards merging PRs but it's by far the best way to get noticed and earn a spot as a community reviewer like myself (highly recommended) 😉

@espositofulvio
Copy link
Contributor Author

@espositofulvio Yes! it's not counted towards merging PRs but it's by far the best way to get noticed and earn a spot as a community reviewer like myself (highly recommended) 😉

Great thanks! I'm re-entering the c++ world after a few years and a project like conan eased my transition back a lot (I'm used to web languages with package managers now) and found that following this repo allows me to get on top of some of the best libraries for C++!

@conan-center-bot conan-center-bot merged commit a184f7a into conan-io:master Jul 5, 2021
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants