-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spirv-tools to 2021.2 #6144
Conversation
This comment has been minimized.
This comment has been minimized.
@prince-chrismc I'm not sure what's happening but two old versions are failing to build even though my changes just add a new version. Could someone check what's the specific error? |
When you change a recipe all the versions are rebuilt to ensure things are in sync. Given everything passed in the logs it might be a random issue in the backend... the CCI infra team might comment on what... For now... |
There are some errors that we label as random. They happen from time to time. Probably they are not random, but we don't have time to investigate (and implement) all of them, usually, there are other priorities 😞 In this case, the two builds have failed with this error:
I know sometimes it can be annoying, we might eventually try to fix this specific error, but there will always be something unexpected. Triggering the build again is usually the (easiest) way to go. |
Hi @jgsogo, thanks for your reply, I've just started using Conan and don't know in depth all the CI build process, but thanks for all your effort, I do think Conan is really wonderful piece of software and I hope to contribute more 😊. I restarted the build as both you and Chris suggested. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Do not continue restarting there might be something wrong |
I thought it was only a matters of the right time. I'll hold off then |
It's still building so we might actually be lucky! |
All green in build 5 (
|
@uilianries, please review. |
@AndreyMlashkin Please be patient! there's lot of PR's that need attention ❤️ We'll get there soon! EDIT: Also thank you I noticed I broken prince-chrismc/conan-center-index-pending-review#1 with prince-chrismc/conan-center-index-pending-review@fbd9c10 🤢 since nothing was marked in review |
@prince-chrismc I'm still learning a bit about the review process, so my question is: am I allowed to review and approve pull requests from other contributors? |
@espositofulvio Yes! it's not counted towards merging PRs but it's by far the best way to get noticed and earn a spot as a community reviewer like myself (highly recommended) 😉 |
Great thanks! I'm re-entering the c++ world after a few years and a project like conan eased my transition back a lot (I'm used to web languages with package managers now) and found that following this repo allows me to get on top of some of the best libraries for C++! |
Specify library name and version: spirv-tools/2021.2
This pull request updates spirv-tools to 2021.2
conan-center hook activated.